From: Ben Laurie <ben@openssl.org>
Date: Sun, 17 Jan 1999 14:10:08 +0000 (+0000)
Subject: Generate an error on an invalid directory.
X-Git-Tag: OpenSSL_0_9_2b~252
X-Git-Url: https://git.openssl.org/?p=openssl.git;a=commitdiff_plain;h=2c1ef383aef7dd7bb419dfcc5554b42facff707e

Generate an error on an invalid directory.
---

diff --git a/CHANGES b/CHANGES
index 97cbdd9fff..c3f7f1890b 100644
--- a/CHANGES
+++ b/CHANGES
@@ -5,6 +5,11 @@
 
  Changes between 0.9.1c and 0.9.2
 
+  *) Generate an error if given an empty string as a cert directory. Also
+     generate an error if handed NULL (previously returned 0 to indicate an
+     error, but didn't set one).
+     [Ben Laurie, reported by Anonymous <nobody@replay.com>]
+
   *) Add prototypes to SSL methods. Make SSL_write's buffer const, at last.
      [Ben Laurie]
 
diff --git a/crypto/x509/by_dir.c b/crypto/x509/by_dir.c
index 11725ec94c..ee47582b00 100644
--- a/crypto/x509/by_dir.c
+++ b/crypto/x509/by_dir.c
@@ -192,7 +192,11 @@ int type;
 	char *s,*ss,*p;
 	char **pp;
 
-	if (dir == NULL) return(0);
+	if (dir == NULL || !*dir)
+	    {
+	    X509err(X509_F_ADD_CERT_DIR,X509_R_INVALID_DIRECTORY);
+	    return 0;
+	    }
 
 	s=dir;
 	p=s;