From: Patrick Steuer <patrick.steuer@de.ibm.com>
Date: Mon, 18 Dec 2017 21:47:01 +0000 (+0100)
Subject: crypto/engine/eng_list.c: compare getenv rv to NULL instead of 0
X-Git-Tag: OpenSSL_1_1_1-pre1~210
X-Git-Url: https://git.openssl.org/?p=openssl.git;a=commitdiff_plain;h=1a49ff5a4ff290b988cd898b41c8504749a468fc;ds=inline

crypto/engine/eng_list.c: compare getenv rv to NULL instead of 0

Signed-off-by: Patrick Steuer <patrick.steuer@de.ibm.com>

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/4958)
---

diff --git a/crypto/engine/eng_list.c b/crypto/engine/eng_list.c
index b335ac1651..53e138d5cb 100644
--- a/crypto/engine/eng_list.c
+++ b/crypto/engine/eng_list.c
@@ -317,7 +317,7 @@ ENGINE *ENGINE_by_id(const char *id)
      * Prevent infinite recursion if we're looking for the dynamic engine.
      */
     if (strcmp(id, "dynamic")) {
-        if ((load_dir = getenv("OPENSSL_ENGINES")) == 0)
+        if ((load_dir = getenv("OPENSSL_ENGINES")) == NULL)
             load_dir = ENGINESDIR;
         iterator = ENGINE_by_id("dynamic");
         if (!iterator || !ENGINE_ctrl_cmd_string(iterator, "ID", id, 0) ||