From: Richard Levitte <levitte@openssl.org>
Date: Thu, 9 Jun 2005 17:28:53 +0000 (+0000)
Subject: When the return type of the function is int, it's better to return an
X-Git-Tag: OpenSSL_0_9_8k^2~2027
X-Git-Url: https://git.openssl.org/?p=openssl.git;a=commitdiff_plain;h=13e393607b23fd47e4d2dbba2188356062fd2a27

When the return type of the function is int, it's better to return an
in than NULL, especially when an error is signalled with a negative
value.
---

diff --git a/crypto/dso/dso_lib.c b/crypto/dso/dso_lib.c
index 0869a646f6..12ad097a28 100644
--- a/crypto/dso/dso_lib.c
+++ b/crypto/dso/dso_lib.c
@@ -472,7 +472,7 @@ int DSO_pathbyaddr(void *addr,char *path,int sz)
 	if (meth->pathbyaddr == NULL)
 		{
 		DSOerr(DSO_F_PATHBYADDR,DSO_R_UNSUPPORTED);
-		return(NULL);
+		return -1;
 		}
 	return (*meth->pathbyaddr)(addr,path,sz);
 	}