From: Richard Levitte <levitte@openssl.org>
Date: Tue, 8 May 2018 18:15:27 +0000 (+0200)
Subject: VMS rand: assign before check, not the other way around
X-Git-Tag: OpenSSL_1_1_1-pre7~85
X-Git-Url: https://git.openssl.org/?p=openssl.git;a=commitdiff_plain;h=06e0950d20d3110849dea28eb78cac4127618b48

VMS rand: assign before check, not the other way around

items->ile3$w_code was checked before it was assigned its value...

Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/6200)
---

diff --git a/crypto/rand/rand_vms.c b/crypto/rand/rand_vms.c
index 0037466ef7..b263f94208 100644
--- a/crypto/rand/rand_vms.c
+++ b/crypto/rand/rand_vms.c
@@ -277,13 +277,13 @@ static size_t prepare_item_list(const struct item_st *items_input,
 
     for (; items_input_num-- > 0; items_input++, items++) {
 
+        items->ile3$w_code = items_input->code;
         /* Special treatment of JPI$_FINALEXC */
         if (items->ile3$w_code == JPI$_FINALEXC)
             items->ile3$w_length = 4;
         else
             items->ile3$w_length = items_input->length;
 
-        items->ile3$w_code = items_input->code;
         items->ile3$ps_bufaddr = databuffer;
         items->ile3$ps_retlen_addr = 0;