Fix memory leak cause by race condition when creating public keys.
authorDr. Stephen Henson <steve@openssl.org>
Tue, 28 Feb 2012 14:47:02 +0000 (14:47 +0000)
committerDr. Stephen Henson <steve@openssl.org>
Tue, 28 Feb 2012 14:47:02 +0000 (14:47 +0000)
Thanks to Ivan Nestlerode <inestlerode@us.ibm.com> for reporting this bug.

crypto/asn1/x_pubkey.c

index d42b6a2..627ec87 100644 (file)
@@ -171,7 +171,16 @@ EVP_PKEY *X509_PUBKEY_get(X509_PUBKEY *key)
                goto error;
                }
 
-       key->pkey = ret;
+       /* Check to see if another thread set key->pkey first */
+       CRYPTO_w_lock(CRYPTO_LOCK_EVP_PKEY);
+       if (key->pkey)
+               {
+               EVP_PKEY_free(ret);
+               ret = key->pkey;
+               }
+       else
+               key->pkey = ret;
+       CRYPTO_w_unlock(CRYPTO_LOCK_EVP_PKEY);
        CRYPTO_add(&ret->references, 1, CRYPTO_LOCK_EVP_PKEY);
 
        return ret;