Make sure to have both upper and mixed case symbols in SYMBOL_VECTOR
authorRichard Levitte <levitte@openssl.org>
Tue, 12 Jan 2016 02:42:56 +0000 (03:42 +0100)
committerRichard Levitte <levitte@openssl.org>
Tue, 12 Jan 2016 03:44:24 +0000 (04:44 +0100)
It was assumed that the syntax FOO/Foo=PROCEDURE would create both an
upper case and mixed case symbol in the GST.  Not so, it requires
having both FOO/Foo=PROCEDURE (to create the upper case alias) and
Foo=PROCEDURE (to create the mixed case slot).

We make sure that any symbol always occupies two slots (even those
that don't exist) by filling up with SPARE when necessary.  That will
assure that any changes will still have the same symbols in the same
slots no matter what (save a complete rewrite of the ordinals files).

Reviewed-by: Rich Salz <rsalz@openssl.org>
util/mkdef.pl

index a2fdada..ff018e9 100755 (executable)
@@ -1304,7 +1304,7 @@ EOF
                                                print OUT "        $s2;\n";
                                         } elsif ($VMS) {
                                             while(++$prevnum < $n) {
-                                                my $symline="SPARE -";
+                                                my $symline="SPARE, SPARE -";
                                                 if ($symvtextcount + length($symline) + 1 > 1024) {
                                                     print OUT ")\nSYMBOL_VECTOR=(-\n";
                                                     $symvtextcount = 16; # length of "SYMBOL_VECTOR=(-"
@@ -1316,8 +1316,13 @@ EOF
                                                 $symvtextcount += length($symline);
                                             }
                                             (my $s_uc = $s) =~ tr/a-z/A-Z/;
-                                            my $symline="$s_uc/$s="
-                                                , ($v ? "DATA" : "PROCEDURE"), " -\n";
+                                            my $symtype=
+                                                $v ? "DATA" : "PROCEDURE";
+                                            my $symline=
+                                                ($s_uc ne $s
+                                                 ? "$s_uc/$s=$symtype, $s=$symtype"
+                                                 : "$s=$symtype, SPARE")
+                                                ." -";
                                             if ($symvtextcount + length($symline) + 1 > 1024) {
                                                 print OUT ")\nSYMBOL_VECTOR=(-\n";
                                                 $symvtextcount = 16; # length of "SYMBOL_VECTOR=(-"