Fix error handling in bn_exp
authorMatt Caswell <matt@openssl.org>
Wed, 11 Mar 2015 15:31:16 +0000 (15:31 +0000)
committerMatt Caswell <matt@openssl.org>
Thu, 12 Mar 2015 09:32:22 +0000 (09:32 +0000)
In the event of an error |rr| could be NULL. Therefore don't assume you can
use |rr| in the error handling code.

Reviewed-by: Andy Polyakov <appro@openssl.org>
(cherry picked from commit 8c5a7b33c6269c3bd6bc0df6b4c22e4fba03b485)

crypto/bn/bn_exp.c

index fca4014..27146c8 100644 (file)
@@ -168,10 +168,10 @@ int BN_exp(BIGNUM *r, const BIGNUM *a, const BIGNUM *p, BN_CTX *ctx)
                 goto err;
         }
     }
-    ret = 1;
- err:
     if (r != rr)
         BN_copy(r, rr);
+    ret = 1;
+ err:
     BN_CTX_end(ctx);
     bn_check_top(r);
     return (ret);