Use strerror_r()/strerror_s() instead of strerror() where possible

The function strerror() is not thread safe. We should use strerror_r()
where possible, or strerror_s() on Windows.

RT#2267

Reviewed-by: Richard Levitte <levitte@openssl.org>

diff --git a/crypto/dso/dso_dl.c b/crypto/dso/dso_dl.c
index f5c51bfe85f01a6855fdc875e40de05dbd944cf3..bc29fb23e03955b12a12a2e5f09318f06d02395d 100644 (file)
--- a/crypto/dso/dso_dl.c
+++ b/crypto/dso/dso_dl.c
@@ -66,8 +66,10 @@ static int dl_load(DSO *dso)
                    (dso->flags & DSO_FLAG_NO_NAME_TRANSLATION ? 0 :
                     DYNAMIC_PATH), 0L);
     if (ptr == NULL) {
                    (dso->flags & DSO_FLAG_NO_NAME_TRANSLATION ? 0 :
                     DYNAMIC_PATH), 0L);
     if (ptr == NULL) {

+        char errbuf[160];

         DSOerr(DSO_F_DL_LOAD, DSO_R_LOAD_FAILED);
         DSOerr(DSO_F_DL_LOAD, DSO_R_LOAD_FAILED);

-        ERR_add_error_data(4, "filename(", filename, "): ", strerror(errno));
+        if (openssl_strerror_r(errno, errbuf, sizeof(errbuf)))
+            ERR_add_error_data(4, "filename(", filename, "): ", errbuf);

         goto err;
     }
     if (!sk_push(dso->meth_data, (char *)ptr)) {
         goto err;
     }
     if (!sk_push(dso->meth_data, (char *)ptr)) {


@@ -130,8 +132,10 @@ static DSO_FUNC_TYPE dl_bind_func(DSO *dso, const char *symname)
         return (NULL);
     }
     if (shl_findsym(&ptr, symname, TYPE_UNDEFINED, &sym) < 0) {
         return (NULL);
     }
     if (shl_findsym(&ptr, symname, TYPE_UNDEFINED, &sym) < 0) {

+        char errbuf[160];

         DSOerr(DSO_F_DL_BIND_FUNC, DSO_R_SYM_FAILURE);
         DSOerr(DSO_F_DL_BIND_FUNC, DSO_R_SYM_FAILURE);

-        ERR_add_error_data(4, "symname(", symname, "): ", strerror(errno));
+        if (openssl_strerror_r(errno, errbuf, sizeof(errbuf)))
+            ERR_add_error_data(4, "symname(", symname, "): ", errbuf);

         return (NULL);
     }
     return ((DSO_FUNC_TYPE)sym);
         return (NULL);
     }
     return ((DSO_FUNC_TYPE)sym);

diff --git a/crypto/err/err.c b/crypto/err/err.c
index 1035e4c749734ec5d871c2e67ccbec46e094169f..9b679d9b48618b66cf57b4a39d91c5303303d4cf 100644 (file)
--- a/crypto/err/err.c
+++ b/crypto/err/err.c
@@ -220,12 +220,8 @@ static void build_SYS_str_reasons(void)
         str->error = (unsigned long)i;
         if (str->string == NULL) {
             char (*dest)[LEN_SYS_STR_REASON] = &(strerror_tab[i - 1]);
         str->error = (unsigned long)i;
         if (str->string == NULL) {
             char (*dest)[LEN_SYS_STR_REASON] = &(strerror_tab[i - 1]);

-            char *src = strerror(i);
-            if (src != NULL) {
-                strncpy(*dest, src, sizeof(*dest));
-                (*dest)[sizeof(*dest) - 1] = '\0';
+            if (openssl_strerror_r(i, *dest, sizeof(*dest)))

                 str->string = *dest;
                 str->string = *dest;

-            }

         }
         if (str->string == NULL)
             str->string = "unknown";
         }
         if (str->string == NULL)
             str->string = "unknown";

diff --git a/crypto/include/internal/cryptlib.h b/crypto/include/internal/cryptlib.h
index 1327dca44672420bdb6d49cbde7f45ea1a8882c1..f2377d1c932db5691053b508049e99c3086e430b 100644 (file)
--- a/crypto/include/internal/cryptlib.h
+++ b/crypto/include/internal/cryptlib.h
@@ -67,6 +67,8 @@ void OPENSSL_showfatal(const char *fmta, ...);
 extern int OPENSSL_NONPIC_relocated;
 void crypto_cleanup_all_ex_data_int(void);
 
 extern int OPENSSL_NONPIC_relocated;
 void crypto_cleanup_all_ex_data_int(void);
 

+int openssl_strerror_r(int errnum, char *buf, size_t buflen);
+

 #ifdef  __cplusplus
 }
 #endif
 #ifdef  __cplusplus
 }
 #endif

diff --git a/crypto/o_str.c b/crypto/o_str.c
index 0ee2c86d8b167b7c2ba7e4f6be825fb1e850a9c4..98eb1631cb044e5fa9fc8f996263ba1cc6f40416 100644 (file)
--- a/crypto/o_str.c
+++ b/crypto/o_str.c
@@ -258,3 +258,31 @@ char *OPENSSL_buf2hexstr(const unsigned char *buffer, long len)
 
     return tmp;
 }
 
     return tmp;
 }

+
+int openssl_strerror_r(int errnum, char *buf, size_t buflen)
+{
+#if defined(OPENSSL_SYS_WINDOWS)
+    if (strerror_s(buf, buflen, errnum) == EINVAL)
+        return 0;
+    return 1;
+#elif (_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE
+    /*
+     * We can use "real" strerror_r. The OpenSSL version differs in that it
+     * gives 1 on success and 0 on failure for consistency with other OpenSSL
+     * functions. Real strerror_r does it the other way around
+     */
+    return !strerror_r(errnum, buf, buflen);
+#else
+    char *err;
+    /* Fall back to non-thread safe strerror()...its all we can do */
+    if (buflen < 2)
+        return 0;
+    err = strerror(errnum);
+    /* Can this ever happen? */
+    if (err == NULL)
+        return 0;
+    strncpy(buf, err, buflen - 1);
+    buf[buflen - 1] = '\0';
+    return 1;
+#endif
+}