Deallocate previously loaded SSL CONF module data
authorTomas Mraz <tmraz@fedoraproject.org>
Tue, 14 Aug 2018 21:43:36 +0000 (17:43 -0400)
committerRich Salz <rsalz@openssl.org>
Tue, 14 Aug 2018 21:43:36 +0000 (17:43 -0400)
If application explicitly calls CONF_modules_load_file() the SSL
conf module will be initialized twice and the module data would leak.
We need to free it before initializing it again.

Fixes #6835

Reviewed-by: Andy Polyakov <appro@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/6948)

crypto/conf/conf_ssl.c

index 015c46c..024bdb4 100644 (file)
@@ -76,6 +76,7 @@ static int ssl_module_init(CONF_IMODULE *md, const CONF *cnf)
         goto err;
     }
     cnt = sk_CONF_VALUE_num(cmd_lists);
+    ssl_module_free(md);
     ssl_names = OPENSSL_zalloc(sizeof(*ssl_names) * cnt);
     ssl_names_count = cnt;
     for (i = 0; i < ssl_names_count; i++) {