Add OPENSSL_strdup failure check to cpt_ctrl() in bss_acpt.c
authorDr. David von Oheimb <David.von.Oheimb@siemens.com>
Thu, 4 Jun 2020 08:33:28 +0000 (10:33 +0200)
committerDr. David von Oheimb <David.von.Oheimb@siemens.com>
Tue, 16 Jun 2020 16:51:39 +0000 (18:51 +0200)
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/11986)

crypto/bio/bss_acpt.c

index 3523f68..7f1af71 100644 (file)
@@ -433,8 +433,10 @@ static long acpt_ctrl(BIO *b, int cmd, long num, void *ptr)
                 b->init = 1;
             } else if (num == 1) {
                 OPENSSL_free(data->param_serv);
-                data->param_serv = OPENSSL_strdup(ptr);
-                b->init = 1;
+                if ((data->param_serv = OPENSSL_strdup(ptr)) == NULL)
+                    ret = 0;
+                else
+                    b->init = 1;
             } else if (num == 2) {
                 data->bind_mode |= BIO_SOCK_NONBLOCK;
             } else if (num == 3) {