Fixed the return code for RAND_egd_bytes.
authorganesh <ganeshbhambarkar@gmail.com>
Thu, 10 Nov 2016 11:16:43 +0000 (16:46 +0530)
committerRichard Levitte <levitte@openssl.org>
Tue, 24 Jan 2017 13:39:20 +0000 (14:39 +0100)
According to the documentation, the return code should be -1 when
RAND_status does not return 1.

Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1886)

crypto/rand/rand_egd.c

index 5fb230f..f77af41 100644 (file)
@@ -228,10 +228,10 @@ int RAND_query_egd_bytes(const char *path, unsigned char *buf, int bytes)
 
 int RAND_egd_bytes(const char *path, int bytes)
 {
-    int num, ret = 0;
+    int num, ret = -1;
 
     num = RAND_query_egd_bytes(path, NULL, bytes);
-    if (num < 1 || RAND_status() == 1)
+    if (RAND_status() == 1)
         ret = num;
  err:
     return (ret);