Add atomic write call

Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/4414)

diff --git a/crypto/threads_none.c b/crypto/threads_none.c
index 7e9ec2d15148eb9636fe0e899120fce653afa600..30ed4e6999cc6c1fbae8fa35d682468e7ab5513f 100644 (file)
--- a/crypto/threads_none.c
+++ b/crypto/threads_none.c
@@ -127,7 +127,13 @@ int CRYPTO_atomic_add(int *val, int amount, int *ret, CRYPTO_RWLOCK *lock)
 
 int CRYPTO_atomic_read(int *val, int *ret, CRYPTO_RWLOCK *lock)
 {
-    *ret  = *val;
+    *ret = *val;
+    return 1;
+}
+
+int CRYPTO_atomic_write(int *val, int n, CRYPTO_RWLOCK *lock)
+{
+    *val = n;
     return 1;
 }
 

diff --git a/crypto/threads_pthread.c b/crypto/threads_pthread.c
index 3f8ada2c370c4843bce53ef0208fb0dfc4a1d0a4..34be314f1fd7cbb4bcff27c1cc4d85c0034ca1a4 100644 (file)
--- a/crypto/threads_pthread.c
+++ b/crypto/threads_pthread.c
@@ -188,6 +188,25 @@ int CRYPTO_atomic_read(int *val, int *ret, CRYPTO_RWLOCK *lock)
     return 1;
 }
 
+int CRYPTO_atomic_write(int *val, int n, CRYPTO_RWLOCK *lock)
+{
+# if defined(__GNUC__) && defined(__ATOMIC_RELEASE)
+    if (__atomic_is_lock_free(sizeof(*val), val)) {
+        __atomic_store(val, &n, __ATOMIC_RELEASE);
+        return 1;
+    }
+# endif
+    if (!CRYPTO_THREAD_write_lock(lock))
+        return 0;
+
+    *val = n;
+
+    if (!CRYPTO_THREAD_unlock(lock))
+        return 0;
+
+    return 1;
+}
+
 # ifdef OPENSSL_SYS_UNIX
 static pthread_once_t fork_once_control = PTHREAD_ONCE_INIT;
 

diff --git a/crypto/threads_win.c b/crypto/threads_win.c
index 6f9c7b1bd398cb08ea791b2047d13bc135d34fb2..ab2eb2574025747aef1dff27b4f62fed6b13d173 100644 (file)
--- a/crypto/threads_win.c
+++ b/crypto/threads_win.c
@@ -139,6 +139,12 @@ int CRYPTO_atomic_read(int *val, int *ret, CRYPTO_RWLOCK *lock)
     return 1;
 }
 
+int CRYPTO_atomic_write(int *val, int n, CRYPTO_RWLOCK *lock)
+{
+    InterlockedExchange(val, n);
+    return 1;
+}
+
 int openssl_init_fork_handlers(void)
 {
     return 0;

diff --git a/doc/man3/CRYPTO_THREAD_run_once.pod b/doc/man3/CRYPTO_THREAD_run_once.pod
index bf4a2f2cefa6fe0acdadfc74011e15e299e55b3b..734d2d887468bf24c91a042aa0cbc5769d57c1ae 100644 (file)
--- a/doc/man3/CRYPTO_THREAD_run_once.pod
+++ b/doc/man3/CRYPTO_THREAD_run_once.pod
@@ -5,7 +5,7 @@
 CRYPTO_THREAD_run_once,
 CRYPTO_THREAD_lock_new, CRYPTO_THREAD_read_lock, CRYPTO_THREAD_write_lock,
 CRYPTO_THREAD_unlock, CRYPTO_THREAD_lock_free, CRYPTO_atomic_add,
-CRYPTO_atomic_read - OpenSSL thread support
+CRYPTO_atomic_read, CRYPTO_atomic_write - OpenSSL thread support
 
 =head1 SYNOPSIS
 
@@ -22,6 +22,7 @@ CRYPTO_atomic_read - OpenSSL thread support
 
  int CRYPTO_atomic_add(int *val, int amount, int *ret, CRYPTO_RWLOCK *lock);
  int CRYPTO_atomic_read(int *val, int *ret, CRYPTO_RWLOCK *lock);
+ int CRYPTO_atomic_write(int *val, int n, CRYPTO_RWLOCK *lock);
 
 =head1 DESCRIPTION
 
@@ -82,6 +83,11 @@ CRYPTO_atomic_read() atomically reads B<val> and returns the result of
 the operation in B<ret>. B<lock> will be locked, unless atomic operations
 are supported on the specific platform.
 
+=item *
+
+CRYPTO_atomic_write() atomically writes B<n> to B<val>. B<lock> will be
+locked, unless atomic operations are supported on the specific platform.
+
 =back
 
 =head1 RETURN VALUES

diff --git a/include/openssl/crypto.h b/include/openssl/crypto.h
index a9f080d53ccc420686ccff66d19dab32cfc19219..c2aa07c98d49d96caafa9b53e7b8bc2f8a2191e0 100644 (file)
--- a/include/openssl/crypto.h
+++ b/include/openssl/crypto.h
@@ -75,6 +75,7 @@ void CRYPTO_THREAD_lock_free(CRYPTO_RWLOCK *lock);
 
 int CRYPTO_atomic_add(int *val, int amount, int *ret, CRYPTO_RWLOCK *lock);
 int CRYPTO_atomic_read(int *val, int *ret, CRYPTO_RWLOCK *lock);
+int CRYPTO_atomic_write(int *val, int n, CRYPTO_RWLOCK *lock);
 
 /*
  * The following can be used to detect memory leaks in the library. If

diff --git a/util/libcrypto.num b/util/libcrypto.num
index 68f89b63020bc059872d0fc61704281f47171cab..5343aeddb729000cf0d94c7007665a1c1a194bd3 100644 (file)
--- a/util/libcrypto.num
+++ b/util/libcrypto.num
@@ -4399,3 +4399,4 @@ EVP_PKEY_meth_get_check                 4342      1_1_1   EXIST::FUNCTION:
 EVP_PKEY_meth_remove                    4343   1_1_1   EXIST::FUNCTION:
 OPENSSL_sk_reserve                      4344   1_1_1   EXIST::FUNCTION:
 CRYPTO_atomic_read                      4345   1_1_1   EXIST::FUNCTION:
+CRYPTO_atomic_write                     4346   1_1_1   EXIST::FUNCTION: