Mark a zero length record as read
authorMatt Caswell <matt@openssl.org>
Mon, 6 Nov 2017 16:52:06 +0000 (16:52 +0000)
committerMatt Caswell <matt@openssl.org>
Tue, 7 Nov 2017 11:07:17 +0000 (11:07 +0000)
If SSL_read() is called with a zero length buffer, and we read a zero length
record then we should mark that record as read.

Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/4685)

ssl/record/rec_layer_s3.c

index 980e5a4..d10b91b 100644 (file)
@@ -1305,8 +1305,16 @@ int ssl3_read_bytes(SSL *s, int type, int *recvd_type, unsigned char *buf,
         if (recvd_type != NULL)
             *recvd_type = SSL3_RECORD_get_type(rr);
 
-        if (len == 0)
+        if (len == 0) {
+            /*
+             * Mark a zero length record as read. This ensures multiple calls to
+             * SSL_read() with a zero length buffer will eventually cause
+             * SSL_pending() to report data as being available.
+             */
+            if (SSL3_RECORD_get_length(rr) == 0)
+                SSL3_RECORD_set_read(rr);
             return 0;
+        }
 
         totalbytes = 0;
         do {