Always duplicate the session on NewSessionTicket in TLSv1.3

Because NST messages arrive post-handshake, the session may have already
gone into the cache. Once in the cache a session must be immutable -
otherwise you could get multi-thread issues.

Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/3008)

diff --git a/ssl/statem/statem_clnt.c b/ssl/statem/statem_clnt.c
index 56c315e974b886b2f8259fa617a98e7e4ed33302..ab77ba05e9ff4416e56f36f3a3c44bb1a84131ee 100644 (file)
--- a/ssl/statem/statem_clnt.c
+++ b/ssl/statem/statem_clnt.c
@@ -2438,7 +2438,15 @@ MSG_PROCESS_RETURN tls_process_new_session_ticket(SSL *s, PACKET *pkt)
     if (ticklen == 0)
         return MSG_PROCESS_CONTINUE_READING;
 
     if (ticklen == 0)
         return MSG_PROCESS_CONTINUE_READING;
 

-    if (s->session->session_id_length > 0) {
+    /*
+     * Sessions must be immutable once they go into the session cache. Otherwise
+     * we can get multi-thread problems. Therefore we don't "update" sessions,
+     * we replace them with a duplicate. In TLSv1.3 we need to do this every
+     * time a NewSessionTicket arrives because those messages arrive
+     * post-handshake and the session may have already gone into the session
+     * cache.
+     */
+    if (SSL_IS_TLS13(s) || s->session->session_id_length > 0) {

         int i = s->session_ctx->session_cache_mode;
         SSL_SESSION *new_sess;
         /*
         int i = s->session_ctx->session_cache_mode;
         SSL_SESSION *new_sess;
         /*