Configurations/10-main.conf: add -fno-common back to darwin-ppc-cc.
authorAndy Polyakov <appro@openssl.org>
Mon, 5 Mar 2018 15:55:48 +0000 (16:55 +0100)
committerAndy Polyakov <appro@openssl.org>
Tue, 6 Mar 2018 22:16:24 +0000 (23:16 +0100)
-fno-common was removed for all Darwin targets in
0c8734198d4282f6997965a03cd2e0ceaf207549 with rationale "it's either
'ranlib -c' or '-fno-common'." However, it's still absolutely required
in 32-bit darwin-ppc-cc. And when trying things out I didn't quite
see why it was formulated as one-or-another choice, as 'ranlib -c'
shouldn't [and doesn't] have problems with object modules without
commons. [Well, to be frank, I didn't manage to reproduce the problem
the modification was meaning to resolve either...]

Reviewed-by: Rich Salz <rsalz@openssl.org>
Configurations/10-main.conf

index 3ee071765db828b76b3625a8ba6b61f60757e331..7f07752511a49e1cb291740b5fa4d8ccf4cea1e8 100644 (file)
@@ -1647,6 +1647,7 @@ my %targets = (
         inherit_from     => [ "darwin-common", asm("ppc32_asm") ],
         cflags           => add("-arch ppc -std=gnu9x -Wa,-force_cpusubtype_ALL"),
         cppflags         => add("-DB_ENDIAN"),
+        shared_cflag     => add("-fno-common"),
         perlasm_scheme   => "osx32",
     },
     "darwin64-ppc-cc" => {