Check the return code from ASN1_TIME_diff()
authorMatt Caswell <matt@openssl.org>
Mon, 12 Feb 2018 17:47:50 +0000 (17:47 +0000)
committerMatt Caswell <matt@openssl.org>
Thu, 15 Feb 2018 15:24:47 +0000 (15:24 +0000)
The function can fail so we should check the return code.

Found by Coverity

Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
(Merged from https://github.com/openssl/openssl/pull/5339)

apps/ca.c

index a416f36..26c0778 100644 (file)
--- a/apps/ca.c
+++ b/apps/ca.c
@@ -1706,7 +1706,9 @@ static int do_body(X509 **xret, EVP_PKEY *pkey, X509 *x509,
 
     if (enddate != NULL) {
         int tdays;
-        ASN1_TIME_diff(&tdays, NULL, NULL, X509_get0_notAfter(ret));
+
+        if (!ASN1_TIME_diff(&tdays, NULL, NULL, X509_get0_notAfter(ret)))
+            goto end;
         days = tdays;
     }