Don't shift serial number into sign bit
authorDr. Stephen Henson <steve@openssl.org>
Fri, 4 Mar 2016 18:04:46 +0000 (18:04 +0000)
committerDr. Stephen Henson <steve@openssl.org>
Mon, 7 Mar 2016 15:19:58 +0000 (15:19 +0000)
Reviewed-by: Rich Salz <rsalz@openssl.org>
(cherry picked from commit 01c32b5e448f6d42a23ff16bdc6bb0605287fa6f)

crypto/asn1/t_x509.c

index 4e7c45d..4f69b51 100644 (file)
@@ -140,7 +140,8 @@ int X509_print_ex(BIO *bp, X509 *x, unsigned long nmflags,
             goto err;
 
         bs = X509_get_serialNumber(x);
-        if (bs->length <= (int)sizeof(long)) {
+        if (bs->length < (int)sizeof(long)
+            || (bs->length == sizeof(long) && (bs->data[0] & 0x80) == 0)) {
             l = ASN1_INTEGER_get(bs);
             if (bs->type == V_ASN1_NEG_INTEGER) {
                 l = -l;