Fix incomplete check on EVP_CIPHER_param_to_asn1()
authorndossche <niels.dossche@ugent.be>
Tue, 31 Jan 2023 12:20:17 +0000 (13:20 +0100)
committerPauli <pauli@openssl.org>
Wed, 1 Feb 2023 23:14:12 +0000 (10:14 +1100)
commite3663717fc16bd140f54ee7f1600bdced7f9ea66
tree962fedaefcd92d1fee89e9d5fe2bbf53b14889df
parentaa2d7e0ee15d1b7015479c38f370a25ceec690fc
Fix incomplete check on EVP_CIPHER_param_to_asn1()

That function is a wrapper around evp_cipher_param_to_asn1_ex() which
can return 0 as an error value via its ret <= 0 check [1].
Furthermore, all other callers of this function check against <= 0
instead of < 0 and this is also in line with what the documentation
tells us. Fix the incomplete check by changing it to <= 0 as well.

CLA: trivial

[1] https://github.com/openssl/openssl/blob/114d99b46bfb212ffc510865df317ca2c1542623/crypto/evp/evp_lib.c#L164-L165

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20180)
crypto/pkcs7/pk7_doit.c