Address some -Wold-style-declaration warnings
authorBenjamin Kaduk <bkaduk@akamai.com>
Fri, 14 Apr 2017 16:53:04 +0000 (11:53 -0500)
committerRich Salz <rsalz@openssl.org>
Mon, 1 May 2017 18:23:28 +0000 (14:23 -0400)
commitf44903a428cc63ce88bfba26e8e4e2e9b21f058d
tree0cc827eb1d22e07660aec7f6bc7d0ed1760de688
parent560ad13c74fe6967991a2429d90eeeba815d1f9e
Address some -Wold-style-declaration warnings

gcc's -Wextra pulls in -Wold-style-declaration, which triggers when a
declaration has a storage-class specifier as a non-initial qualifier.
The ISO C formal grammar requires the storage-class to be the first
component of the declaration, if present.

Seeint as the register storage-class specifier does not really have any effect
anymore with modern compilers, remove it entirely while we're here, instead of
fixing up the order.

Interestingly, the gcc devteam warnings do not pull in -Wextra, though
the clang ones do.

[extended tests]

Reviewed-by: Andy Polyakov <appro@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/3239)
crypto/cast/c_enc.c
crypto/ec/ecp_nistz256.c
crypto/include/internal/bn_dh.h
crypto/o_str.c
test/chacha_internal_test.c
test/wpackettest.c