Fix reachable assert in SSLv2 servers.
authorEmilia Kasper <emilia@openssl.org>
Wed, 4 Mar 2015 17:05:02 +0000 (09:05 -0800)
committerMatt Caswell <matt@openssl.org>
Thu, 19 Mar 2015 12:59:31 +0000 (12:59 +0000)
commitcd56a08d4e1dcae6a0ad8a5b39512fb80ccd1b73
treebb82ef9b4dcb43b3dcadb26a18083981d88e060a
parente2acb69c760f681b070a20defe5510272492a7e8
Fix reachable assert in SSLv2 servers.

This assert is reachable for servers that support SSLv2 and export ciphers.
Therefore, such servers can be DoSed by sending a specially crafted
SSLv2 CLIENT-MASTER-KEY.

Also fix s2_srvr.c to error out early if the key lengths are malformed.
These lengths are sent unencrypted, so this does not introduce an oracle.

CVE-2015-0293

This issue was discovered by Sean Burford (Google) and Emilia Käsper of
the OpenSSL development team.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
ssl/s2_lib.c
ssl/s2_srvr.c