CRYPTO_mem_debug_push() and CRYPTO_mem_debug_pop() should return 0
authorMatt Caswell <matt@openssl.org>
Tue, 9 Aug 2022 10:59:22 +0000 (11:59 +0100)
committerTomas Mraz <tomas@openssl.org>
Wed, 17 Aug 2022 10:58:43 +0000 (12:58 +0200)
commitb89f113149b7bd5173f4100884aab354ad6da74d
tree3e1e0c58c49745a2b1c21d90d440f249c0dc8765
parent5a07d91dc9e787e5e4a2ff5b41bc0ebdcb4efd0a
CRYPTO_mem_debug_push() and CRYPTO_mem_debug_pop() should return 0

Those 2 functions historically only ever returned 0 or 1. In OpenSSL 3.0
they were made no-ops and the documentation says they always return 0. In
fact they were returning -1. If any application was actually using these
functions then it may appear that they were actually successful (e.g. -1
could be interpreted as "true").

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18967)

(cherry picked from commit f868454257560c78570549f6a34d5918f03898a0)
crypto/mem.c