Handle SSL_shutdown while in init more appropriately
authorMatt Caswell <matt@openssl.org>
Mon, 7 Dec 2015 16:50:38 +0000 (16:50 +0000)
committerMatt Caswell <matt@openssl.org>
Wed, 20 Jan 2016 13:58:12 +0000 (13:58 +0000)
commit7bb196a71adef8440b6152b6174651a9c25588f1
tree01e909a54f822db8de9e26c768441aa33ee763ef
parent3aeb93486588e7dd01379c50b8fd496d55cf8858
Handle SSL_shutdown while in init more appropriately

Calling SSL_shutdown while in init previously gave a "1" response, meaning
everything was successfully closed down (even though it wasn't). Better is
to send our close_notify, but fail when trying to receive one.

The problem with doing a shutdown while in the middle of a handshake is
that once our close_notify is sent we shouldn't really do anything else
(including process handshake/CCS messages) until we've received a
close_notify back from the peer. However the peer might send a CCS before
acting on our close_notify - so we won't be able to read it because we're
not acting on CCS messages!

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
include/openssl/ssl.h
ssl/s3_lib.c
ssl/ssl_err.c
ssl/ssl_lib.c