SSL_get_shared_sigalgs: handle negative idx parameter
authorPeter Wu <peter@lekensteyn.nl>
Thu, 2 Feb 2017 11:11:10 +0000 (12:11 +0100)
committerMatt Caswell <matt@openssl.org>
Thu, 9 Feb 2017 09:48:46 +0000 (09:48 +0000)
commit6d047e06e67cd1f6d83a52b83643e96b4cdbfb51
tree236b80510a9b6fb8a0a1ecb5d2a48b7e7c6823c0
parent68a55f3b451060c747986aeffa322d32c770dd62
SSL_get_shared_sigalgs: handle negative idx parameter

When idx is negative (as is the case with do_print_sigalgs in
apps/s_cb.c), AddressSanitizer complains about a buffer overflow (read).
Even if the pointer is not dereferenced, this is undefined behavior.

Change the user not to use "-1" as index since the function is
documented to return 0 on out-of-range values.

Tested with `openssl s_server` and `curl -k https://localhost:4433`.

Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/2349)
apps/s_cb.c
ssl/t1_lib.c