Detect and prevent recursive config parsing
authorNeil Horman <nhorman@openssl.org>
Thu, 30 Nov 2023 19:28:09 +0000 (14:28 -0500)
committerNeil Horman <nhorman@openssl.org>
Thu, 21 Dec 2023 18:38:31 +0000 (13:38 -0500)
commit682fd21afb5428b5716e62eaefb09a7419f9cfd7
tree71fb0a05bcde1b208ae8c47ddb2ded95e9bc284c
parent506ff20662a228b17840f0b49865a927a45c2908
Detect and prevent recursive config parsing

If a malformed config file is provided such as the following:

openssl_conf = openssl_init
[openssl_init]
providers = provider_sect
[provider_sect]
 = provider_sect

The config parsing library will crash overflowing the stack, as it
recursively parses the same provider_sect ad nauseum.

Prevent this by maintaing a list of visited nodes as we recurse through
referenced sections, and erroring out in the event we visit any given
section node more than once.

Note, adding the test for this revealed that our diagnostic code
inadvertently pops recorded errors off the error stack because
provider_conf_load returns success even in the event that a
configuration parse failed. The call path to provider_conf_load has been
updated in this commit to address that shortcoming, allowing recorded
errors to be visibile to calling applications.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22898)
crypto/conf/conf_err.c
crypto/err/openssl.txt
crypto/provider_conf.c
include/crypto/conferr.h
include/openssl/conferr.h
test/build.info
test/prov_config_test.c
test/recipes/30-test_prov_config.t
test/recursive.cnf [new file with mode: 0644]