Enhance code safety and readability in SSL_get_shared_ciphers()
authorSumitra Sharma <sumitraartsy@gmail.com>
Tue, 12 Sep 2023 06:30:21 +0000 (12:00 +0530)
committerTomas Mraz <tomas@openssl.org>
Mon, 18 Sep 2023 12:10:17 +0000 (14:10 +0200)
commit2743594d73e65c38375c619e89ec62579e2c24a9
treed520ff1f6365cfb37b0e4d85f945a9be74f06b5a
parent861027ffd06019baf82148837e30a992ca9b055e
Enhance code safety and readability in SSL_get_shared_ciphers()

This commit introduces two key improvements:

1. Improve code safety by replacing the conditional statement with
`if (n >= size)` and using OPENSSL_strnlen() instead of strlen().
This change ensures proper buffer size handling and adheres to
secure coding practices.

2. Enhance code readability by substituting `strcpy(p, c->name)` with
`memcpy(p, c->name, n)`. This adjustment prioritizes code clarity and
maintenance, even while mitigating a minimal buffer overflow risk.

These enhancements bolster the code's robustness and comprehensibility,
aligning with secure coding principles and best practices.

Fixes #19837

Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21934)
ssl/ssl_lib.c