Don't (re-)initialize the FFC_PARAMs in dh_init and dsa_init
authorMatthias St. Pierre <matthias.st.pierre@ncp-e.com>
Mon, 2 Oct 2023 10:10:01 +0000 (12:10 +0200)
committerTomas Mraz <tomas@openssl.org>
Wed, 4 Oct 2023 10:22:04 +0000 (12:22 +0200)
commit706512ecbc31585d447b53c3aa89acdf6951f996
treeca8ae1ece495147c8779ccaefa90926f4a2a3148
parent860e36d0dd72f4aa4791e88aa185cb42065a30c4
Don't (re-)initialize the FFC_PARAMs in dh_init and dsa_init

The initialization was introduced in commit dc8de3e6f1ee and
changes the behaviour of the `init` method for DSA and DH
between 1.1.1 and 3.0, while the behaviour for RSA and EC_KEY
remains unchanged.

The initialization is not necessary in 3.x and master imho and
breaks the use-case of intercepting the methods of an existing
key.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22185)
crypto/dh/dh_key.c
crypto/dh/dh_lib.c
crypto/dsa/dsa_lib.c
crypto/dsa/dsa_ossl.c