X-Git-Url: https://git.openssl.org/?p=openssl.git;a=blobdiff_plain;f=crypto%2Frand%2Fdrbg_lib.c;h=80759cbfaf9d4956105f7b66aeaba9ac09c759d4;hp=94a4e98d73aedb153b9cf42f716d8cf080eecccc;hb=f000e82898af251442ca52e81fc1ee45996090dc;hpb=a998b85a4f0e706fa6a07b7feab557d9e570d372 diff --git a/crypto/rand/drbg_lib.c b/crypto/rand/drbg_lib.c index 94a4e98d73..80759cbfaf 100644 --- a/crypto/rand/drbg_lib.c +++ b/crypto/rand/drbg_lib.c @@ -11,10 +11,10 @@ #include #include #include +#include #include "rand_local.h" #include "internal/thread_once.h" #include "crypto/rand.h" -#include "crypto/rand_pool.h" #include "crypto/cryptlib.h" /* @@ -37,6 +37,7 @@ typedef struct drbg_global_st { * * There are three shared DRBG instances: , , and . */ + CRYPTO_RWLOCK *lock; /* * The DRBG @@ -70,14 +71,6 @@ typedef struct drbg_global_st { CRYPTO_THREAD_LOCAL private_drbg; } DRBG_GLOBAL; -typedef struct drbg_nonce_global_st { - CRYPTO_RWLOCK *rand_nonce_lock; - int rand_nonce_count; -} DRBG_NONCE_GLOBAL; - -/* NIST SP 800-90A DRBG recommends the use of a personalization string. */ -static const char ossl_pers_string[] = DRBG_DEFAULT_PERS_STRING; - #define RAND_DRBG_TYPE_FLAGS ( \ RAND_DRBG_FLAG_MASTER | RAND_DRBG_FLAG_PUBLIC | RAND_DRBG_FLAG_PRIVATE ) @@ -110,45 +103,76 @@ static const unsigned int rand_drbg_used_flags = static RAND_DRBG *drbg_setup(OPENSSL_CTX *ctx, RAND_DRBG *parent, int drbg_type); -static RAND_DRBG *rand_drbg_new(OPENSSL_CTX *ctx, - int secure, - int type, - unsigned int flags, - RAND_DRBG *parent); - -static int rand_drbg_set(RAND_DRBG *drbg, int type, unsigned int flags); -static int rand_drbg_init_method(RAND_DRBG *drbg); - -static int is_ctr(int type) +static int get_drbg_params(int type, unsigned int flags, const char **name, + OSSL_PARAM params[3]) { + OSSL_PARAM *p = params; + switch (type) { - case NID_aes_128_ctr: - case NID_aes_192_ctr: - case NID_aes_256_ctr: + case 0: return 1; default: return 0; + +#define CTR(v) \ + *name = "CTR-DRBG"; \ + *p++ = OSSL_PARAM_construct_utf8_string(OSSL_DRBG_PARAM_CIPHER, v, 0) + + case NID_aes_128_ctr: + CTR(SN_aes_128_ctr); + break; + case NID_aes_192_ctr: + CTR(SN_aes_192_ctr); + break; + case NID_aes_256_ctr: + CTR(SN_aes_256_ctr); + break; + +#define DGST(v) \ + *p++ = OSSL_PARAM_construct_utf8_string(OSSL_DRBG_PARAM_DIGEST, v, 0); \ + if ((flags & RAND_DRBG_FLAG_HMAC) == 0) { \ + *name = "HASH-DRBG"; \ + } else { \ + *name = "HMAC-DRBG"; \ + *p++ = OSSL_PARAM_construct_utf8_string(OSSL_DRBG_PARAM_MAC, \ + SN_hmac, 0); \ } -} -static int is_digest(int type) -{ - switch (type) { case NID_sha1: + DGST(SN_sha1); + break; case NID_sha224: + DGST(SN_sha224); + break; case NID_sha256: + DGST(SN_sha256); + break; case NID_sha384: + DGST(SN_sha384); + break; case NID_sha512: + DGST(SN_sha512); + break; case NID_sha512_224: + DGST(SN_sha512_224); + break; case NID_sha512_256: + DGST(SN_sha512_256); + break; case NID_sha3_224: + DGST(SN_sha3_224); + break; case NID_sha3_256: + DGST(SN_sha3_256); + break; case NID_sha3_384: + DGST(SN_sha3_384); + break; case NID_sha3_512: - return 1; - default: - return 0; + DGST(SN_sha3_512); } + *p = OSSL_PARAM_construct_end(); + return 1; } /* @@ -170,23 +194,23 @@ static void *drbg_ossl_ctx_new(OPENSSL_CTX *libctx) OPENSSL_init_crypto(0, NULL); #endif + dgbl->lock = CRYPTO_THREAD_lock_new(); + if (dgbl->lock == NULL) + goto err0; + if (!CRYPTO_THREAD_init_local(&dgbl->private_drbg, NULL)) goto err1; if (!CRYPTO_THREAD_init_local(&dgbl->public_drbg, NULL)) goto err2; - dgbl->master_drbg = drbg_setup(libctx, NULL, RAND_DRBG_TYPE_MASTER); - if (dgbl->master_drbg == NULL) - goto err3; - return dgbl; - err3: - CRYPTO_THREAD_cleanup_local(&dgbl->public_drbg); err2: CRYPTO_THREAD_cleanup_local(&dgbl->private_drbg); err1: + CRYPTO_THREAD_lock_free(dgbl->lock); + err0: OPENSSL_free(dgbl); return NULL; } @@ -198,6 +222,7 @@ static void drbg_ossl_ctx_free(void *vdgbl) if (dgbl == NULL) return; + CRYPTO_THREAD_lock_free(dgbl->lock); RAND_DRBG_free(dgbl->master_drbg); CRYPTO_THREAD_cleanup_local(&dgbl->private_drbg); CRYPTO_THREAD_cleanup_local(&dgbl->public_drbg); @@ -210,104 +235,12 @@ static const OPENSSL_CTX_METHOD drbg_ossl_ctx_method = { drbg_ossl_ctx_free, }; -/* - * drbg_ossl_ctx_new() calls drgb_setup() which calls rand_drbg_get_nonce() - * which needs to get the rand_nonce_lock out of the OPENSSL_CTX...but since - * drbg_ossl_ctx_new() hasn't finished running yet we need the rand_nonce_lock - * to be in a different global data object. Otherwise we will go into an - * infinite recursion loop. - */ -static void *drbg_nonce_ossl_ctx_new(OPENSSL_CTX *libctx) -{ - DRBG_NONCE_GLOBAL *dngbl = OPENSSL_zalloc(sizeof(*dngbl)); - - if (dngbl == NULL) - return NULL; - - dngbl->rand_nonce_lock = CRYPTO_THREAD_lock_new(); - if (dngbl->rand_nonce_lock == NULL) { - OPENSSL_free(dngbl); - return NULL; - } - - return dngbl; -} - -static void drbg_nonce_ossl_ctx_free(void *vdngbl) -{ - DRBG_NONCE_GLOBAL *dngbl = vdngbl; - - if (dngbl == NULL) - return; - - CRYPTO_THREAD_lock_free(dngbl->rand_nonce_lock); - - OPENSSL_free(dngbl); -} - -static const OPENSSL_CTX_METHOD drbg_nonce_ossl_ctx_method = { - drbg_nonce_ossl_ctx_new, - drbg_nonce_ossl_ctx_free, -}; - static DRBG_GLOBAL *drbg_get_global(OPENSSL_CTX *libctx) { return openssl_ctx_get_data(libctx, OPENSSL_CTX_DRBG_INDEX, &drbg_ossl_ctx_method); } -/* Implements the get_nonce() callback (see RAND_DRBG_set_callbacks()) */ -size_t rand_drbg_get_nonce(RAND_DRBG *drbg, - unsigned char **pout, - int entropy, size_t min_len, size_t max_len) -{ - size_t ret = 0; - RAND_POOL *pool; - DRBG_NONCE_GLOBAL *dngbl - = openssl_ctx_get_data(drbg->libctx, OPENSSL_CTX_DRBG_NONCE_INDEX, - &drbg_nonce_ossl_ctx_method); - struct { - void *instance; - int count; - } data; - - if (dngbl == NULL) - return 0; - - memset(&data, 0, sizeof(data)); - pool = rand_pool_new(0, 0, min_len, max_len); - if (pool == NULL) - return 0; - - if (rand_pool_add_nonce_data(pool) == 0) - goto err; - - data.instance = drbg; - CRYPTO_atomic_add(&dngbl->rand_nonce_count, 1, &data.count, - dngbl->rand_nonce_lock); - - if (rand_pool_add(pool, (unsigned char *)&data, sizeof(data), 0) == 0) - goto err; - - ret = rand_pool_length(pool); - *pout = rand_pool_detach(pool); - - err: - rand_pool_free(pool); - - return ret; -} - -/* - * Implements the cleanup_nonce() callback (see RAND_DRBG_set_callbacks()) - * - */ -void rand_drbg_cleanup_nonce(RAND_DRBG *drbg, - unsigned char *out, size_t outlen) -{ - OPENSSL_clear_free(out, outlen); -} - /* * Set the |drbg|'s callback data pointer for the entropy and nonce callbacks * @@ -322,8 +255,8 @@ void rand_drbg_cleanup_nonce(RAND_DRBG *drbg, */ int RAND_DRBG_set_callback_data(RAND_DRBG *drbg, void *data) { - if (drbg->state != DRBG_UNINITIALISED - || drbg->parent != NULL) + if (EVP_RAND_state(drbg->rand) != EVP_RAND_STATE_UNINITIALISED + || drbg->parent != NULL) return 0; drbg->callback_data = data; @@ -345,68 +278,71 @@ void *RAND_DRBG_get_callback_data(RAND_DRBG *drbg) */ int RAND_DRBG_set(RAND_DRBG *drbg, int type, unsigned int flags) { - return rand_drbg_set(drbg, type, flags) && rand_drbg_init_method(drbg); -} + OSSL_PARAM params[6], *p = params; + unsigned int reseed_interval; + time_t reseed_time_interval; + const char *name = NULL; + EVP_RAND *rand; + EVP_RAND_CTX *pctx; + int use_df; -static int rand_drbg_set(RAND_DRBG *drbg, int type, unsigned int flags) -{ if (type == 0 && flags == 0) { type = rand_drbg_type[RAND_DRBG_TYPE_MASTER]; flags = rand_drbg_flags[RAND_DRBG_TYPE_MASTER]; } - /* If set is called multiple times - clear the old one */ - if (drbg->type != 0 && (type != drbg->type || flags != drbg->flags)) { - if (drbg->meth != NULL) - drbg->meth->uninstantiate(drbg); - rand_pool_free(drbg->adin_pool); - drbg->adin_pool = NULL; + if (drbg->parent == NULL) { + reseed_interval = master_reseed_interval; + reseed_time_interval = master_reseed_time_interval; + } else { + reseed_interval = slave_reseed_interval; + reseed_time_interval = slave_reseed_time_interval; + } + *p++ = OSSL_PARAM_construct_uint(OSSL_DRBG_PARAM_RESEED_REQUESTS, + &reseed_interval); + *p++ = OSSL_PARAM_construct_time_t(OSSL_DRBG_PARAM_RESEED_TIME_INTERVAL, + &reseed_time_interval); + use_df = (flags & RAND_DRBG_FLAG_CTR_NO_DF) == 0; + *p++ = OSSL_PARAM_construct_int(OSSL_DRBG_PARAM_USE_DF, &use_df); + + if (!get_drbg_params(type, flags, &name, p)) { + RANDerr(0, RAND_R_UNSUPPORTED_DRBG_TYPE); + return 0; } - drbg->state = DRBG_UNINITIALISED; + rand = EVP_RAND_fetch(drbg->libctx, name, NULL); + if (rand == NULL) { + RANDerr(0, RAND_R_NO_DRBG_IMPLEMENTATION_SELECTED); + return 0; + } + + EVP_RAND_CTX_free(drbg->rand); + drbg->rand = NULL; + drbg->flags = flags; drbg->type = type; - drbg->meth = NULL; - if (type == 0 || is_ctr(type) || is_digest(type)) - return 1; + pctx = drbg->parent != NULL ? drbg->parent->rand : NULL; + drbg->rand = EVP_RAND_CTX_new(rand, pctx); + EVP_RAND_free(rand); + if (drbg->rand == NULL) { + RANDerr(0, RAND_R_NO_DRBG_IMPLEMENTATION_SELECTED); + goto err; + } + if (!EVP_RAND_set_ctx_params(drbg->rand, params)) { + RANDerr(0, RAND_R_ERROR_INITIALISING_DRBG); + goto err; + } + return 1; +err: + EVP_RAND_CTX_free(drbg->rand); + drbg->rand = NULL; drbg->type = 0; drbg->flags = 0; - RANDerr(RAND_F_RAND_DRBG_SET, RAND_R_UNSUPPORTED_DRBG_TYPE); - return 0; } -static int rand_drbg_init_method(RAND_DRBG *drbg) -{ - int ret; - - if (drbg->meth != NULL) - return 1; - - if (is_ctr(drbg->type)) { - ret = drbg_ctr_init(drbg); - } else if (is_digest(drbg->type)) { - if (drbg->flags & RAND_DRBG_FLAG_HMAC) - ret = drbg_hmac_init(drbg); - else - ret = drbg_hash_init(drbg); - } else { - /* other cases should already be excluded */ - RANDerr(RAND_F_RAND_DRBG_INIT_METHOD, ERR_R_INTERNAL_ERROR); - drbg->type = 0; - drbg->flags = 0; - return 0; - } - - if (ret == 0) { - drbg->state = DRBG_ERROR; - RANDerr(RAND_F_RAND_DRBG_INIT_METHOD, RAND_R_ERROR_INITIALISING_DRBG); - } - return ret; -} - /* * Set/initialize default |type| and |flag| for new drbg instances. * @@ -415,7 +351,10 @@ static int rand_drbg_init_method(RAND_DRBG *drbg) int RAND_DRBG_set_defaults(int type, unsigned int flags) { int all; - if (!(is_digest(type) || is_ctr(type))) { + const char *name; + OSSL_PARAM params[3]; + + if (!get_drbg_params(type, flags, &name, params)) { RANDerr(RAND_F_RAND_DRBG_SET_DEFAULTS, RAND_R_UNSUPPORTED_DRBG_TYPE); return 0; } @@ -443,20 +382,17 @@ int RAND_DRBG_set_defaults(int type, unsigned int flags) /* - * Allocate memory and initialize a new DRBG. The DRBG is allocated on - * the secure heap if |secure| is nonzero and the secure heap is enabled. + * Allocate memory and initialize a new DRBG. * The |parent|, if not NULL, will be used as random source for reseeding. * * Returns a pointer to the new DRBG instance on success, NULL on failure. */ static RAND_DRBG *rand_drbg_new(OPENSSL_CTX *ctx, - int secure, int type, unsigned int flags, RAND_DRBG *parent) { - RAND_DRBG *drbg = secure ? OPENSSL_secure_zalloc(sizeof(*drbg)) - : OPENSSL_zalloc(sizeof(*drbg)); + RAND_DRBG *drbg = OPENSSL_zalloc(sizeof(*drbg)); if (drbg == NULL) { RANDerr(RAND_F_RAND_DRBG_NEW, ERR_R_MALLOC_FAILURE); @@ -464,49 +400,11 @@ static RAND_DRBG *rand_drbg_new(OPENSSL_CTX *ctx, } drbg->libctx = ctx; - drbg->secure = secure && CRYPTO_secure_allocated(drbg); - drbg->fork_id = openssl_get_fork_id(); drbg->parent = parent; - if (parent == NULL) { - drbg->get_entropy = rand_drbg_get_entropy; - drbg->cleanup_entropy = rand_drbg_cleanup_entropy; -#ifndef RAND_DRBG_GET_RANDOM_NONCE - drbg->get_nonce = rand_drbg_get_nonce; - drbg->cleanup_nonce = rand_drbg_cleanup_nonce; -#endif - - drbg->reseed_interval = master_reseed_interval; - drbg->reseed_time_interval = master_reseed_time_interval; - } else { - drbg->get_entropy = rand_drbg_get_entropy; - drbg->cleanup_entropy = rand_drbg_cleanup_entropy; - /* - * Do not provide nonce callbacks, the child DRBGs will - * obtain their nonce using random bits from the parent. - */ - - drbg->reseed_interval = slave_reseed_interval; - drbg->reseed_time_interval = slave_reseed_time_interval; - } - if (RAND_DRBG_set(drbg, type, flags) == 0) goto err; - if (parent != NULL) { - rand_drbg_lock(parent); - if (drbg->strength > parent->strength) { - /* - * We currently don't support the algorithm from NIST SP 800-90C - * 10.1.2 to use a weaker DRBG as source - */ - rand_drbg_unlock(parent); - RANDerr(RAND_F_RAND_DRBG_NEW, RAND_R_PARENT_STRENGTH_TOO_WEAK); - goto err; - } - rand_drbg_unlock(parent); - } - return drbg; err: @@ -518,7 +416,7 @@ static RAND_DRBG *rand_drbg_new(OPENSSL_CTX *ctx, RAND_DRBG *RAND_DRBG_new_ex(OPENSSL_CTX *ctx, int type, unsigned int flags, RAND_DRBG *parent) { - return rand_drbg_new(ctx, 0, type, flags, parent); + return rand_drbg_new(ctx, type, flags, parent); } RAND_DRBG *RAND_DRBG_new(int type, unsigned int flags, RAND_DRBG *parent) @@ -526,16 +424,6 @@ RAND_DRBG *RAND_DRBG_new(int type, unsigned int flags, RAND_DRBG *parent) return RAND_DRBG_new_ex(NULL, type, flags, parent); } -RAND_DRBG *RAND_DRBG_secure_new_ex(OPENSSL_CTX *ctx, int type, - unsigned int flags, RAND_DRBG *parent) -{ - return rand_drbg_new(ctx, 1, type, flags, parent); -} - -RAND_DRBG *RAND_DRBG_secure_new(int type, unsigned int flags, RAND_DRBG *parent) -{ - return RAND_DRBG_secure_new_ex(NULL, type, flags, parent); -} /* * Uninstantiate |drbg| and free all memory. */ @@ -544,18 +432,8 @@ void RAND_DRBG_free(RAND_DRBG *drbg) if (drbg == NULL) return; - if (drbg->meth != NULL) - drbg->meth->uninstantiate(drbg); - rand_pool_free(drbg->adin_pool); - CRYPTO_THREAD_lock_free(drbg->lock); -#ifndef FIPS_MODULE CRYPTO_free_ex_data(CRYPTO_EX_INDEX_RAND_DRBG, drbg, &drbg->ex_data); -#endif - - if (drbg->secure) - OPENSSL_secure_clear_free(drbg, sizeof(*drbg)); - else - OPENSSL_clear_free(drbg, sizeof(*drbg)); + OPENSSL_free(drbg); } /* @@ -569,92 +447,8 @@ void RAND_DRBG_free(RAND_DRBG *drbg) int RAND_DRBG_instantiate(RAND_DRBG *drbg, const unsigned char *pers, size_t perslen) { - unsigned char *nonce = NULL, *entropy = NULL; - size_t noncelen = 0, entropylen = 0; - size_t min_entropy, min_entropylen, max_entropylen; - - if (drbg->meth == NULL && !rand_drbg_init_method(drbg)) { - RANDerr(RAND_F_RAND_DRBG_INSTANTIATE, - RAND_R_NO_DRBG_IMPLEMENTATION_SELECTED); - goto end; - } - - min_entropy = drbg->strength; - min_entropylen = drbg->min_entropylen; - max_entropylen = drbg->max_entropylen; - - if (perslen > drbg->max_perslen) { - RANDerr(RAND_F_RAND_DRBG_INSTANTIATE, - RAND_R_PERSONALISATION_STRING_TOO_LONG); - goto end; - } - - if (drbg->state != DRBG_UNINITIALISED) { - if (drbg->state == DRBG_ERROR) - RANDerr(RAND_F_RAND_DRBG_INSTANTIATE, RAND_R_IN_ERROR_STATE); - else - RANDerr(RAND_F_RAND_DRBG_INSTANTIATE, RAND_R_ALREADY_INSTANTIATED); - goto end; - } - - drbg->state = DRBG_ERROR; - - /* - * NIST SP800-90Ar1 section 9.1 says you can combine getting the entropy - * and nonce in 1 call by increasing the entropy with 50% and increasing - * the minimum length to accommodate the length of the nonce. - * We do this in case a nonce is require and get_nonce is NULL. - */ - if (drbg->min_noncelen > 0 && drbg->get_nonce == NULL) { - min_entropy += drbg->strength / 2; - min_entropylen += drbg->min_noncelen; - max_entropylen += drbg->max_noncelen; - } - - drbg->reseed_next_counter = tsan_load(&drbg->reseed_prop_counter); - if (drbg->reseed_next_counter) { - drbg->reseed_next_counter++; - if(!drbg->reseed_next_counter) - drbg->reseed_next_counter = 1; - } - - if (drbg->get_entropy != NULL) - entropylen = drbg->get_entropy(drbg, &entropy, min_entropy, - min_entropylen, max_entropylen, 0); - if (entropylen < min_entropylen - || entropylen > max_entropylen) { - RANDerr(RAND_F_RAND_DRBG_INSTANTIATE, RAND_R_ERROR_RETRIEVING_ENTROPY); - goto end; - } - - if (drbg->min_noncelen > 0 && drbg->get_nonce != NULL) { - noncelen = drbg->get_nonce(drbg, &nonce, drbg->strength / 2, - drbg->min_noncelen, drbg->max_noncelen); - if (noncelen < drbg->min_noncelen || noncelen > drbg->max_noncelen) { - RANDerr(RAND_F_RAND_DRBG_INSTANTIATE, RAND_R_ERROR_RETRIEVING_NONCE); - goto end; - } - } - - if (!drbg->meth->instantiate(drbg, entropy, entropylen, - nonce, noncelen, pers, perslen)) { - RANDerr(RAND_F_RAND_DRBG_INSTANTIATE, RAND_R_ERROR_INSTANTIATING_DRBG); - goto end; - } - - drbg->state = DRBG_READY; - drbg->reseed_gen_counter = 1; - drbg->reseed_time = time(NULL); - tsan_store(&drbg->reseed_prop_counter, drbg->reseed_next_counter); - - end: - if (entropy != NULL && drbg->cleanup_entropy != NULL) - drbg->cleanup_entropy(drbg, entropy, entropylen); - if (nonce != NULL && drbg->cleanup_nonce != NULL) - drbg->cleanup_nonce(drbg, nonce, noncelen); - if (drbg->state == DRBG_READY) - return 1; - return 0; + return EVP_RAND_instantiate(drbg->rand, EVP_RAND_strength(drbg->rand), 0, + pers, perslen); } /* @@ -667,10 +461,9 @@ int RAND_DRBG_instantiate(RAND_DRBG *drbg, int RAND_DRBG_uninstantiate(RAND_DRBG *drbg) { int index = -1, type, flags; - if (drbg->meth != NULL) { - drbg->meth->uninstantiate(drbg); - drbg->meth = NULL; - } + + if (!EVP_RAND_uninstantiate(drbg->rand)) + return 0; /* The reset uses the default values for type and flags */ if (drbg->flags & RAND_DRBG_FLAG_MASTER) @@ -687,7 +480,7 @@ int RAND_DRBG_uninstantiate(RAND_DRBG *drbg) flags = drbg->flags; type = drbg->type; } - return rand_drbg_set(drbg, type, flags); + return RAND_DRBG_set(drbg, type, flags); } /* @@ -701,288 +494,152 @@ int RAND_DRBG_reseed(RAND_DRBG *drbg, const unsigned char *adin, size_t adinlen, int prediction_resistance) { - unsigned char *entropy = NULL; - size_t entropylen = 0; - - if (drbg->state == DRBG_ERROR) { - RANDerr(RAND_F_RAND_DRBG_RESEED, RAND_R_IN_ERROR_STATE); - return 0; - } - if (drbg->state == DRBG_UNINITIALISED) { - RANDerr(RAND_F_RAND_DRBG_RESEED, RAND_R_NOT_INSTANTIATED); - return 0; - } - - if (adin == NULL) { - adinlen = 0; - } else if (adinlen > drbg->max_adinlen) { - RANDerr(RAND_F_RAND_DRBG_RESEED, RAND_R_ADDITIONAL_INPUT_TOO_LONG); - return 0; - } - - drbg->state = DRBG_ERROR; - - drbg->reseed_next_counter = tsan_load(&drbg->reseed_prop_counter); - if (drbg->reseed_next_counter) { - drbg->reseed_next_counter++; - if(!drbg->reseed_next_counter) - drbg->reseed_next_counter = 1; - } - - if (drbg->get_entropy != NULL) - entropylen = drbg->get_entropy(drbg, &entropy, drbg->strength, - drbg->min_entropylen, - drbg->max_entropylen, - prediction_resistance); - if (entropylen < drbg->min_entropylen - || entropylen > drbg->max_entropylen) { - RANDerr(RAND_F_RAND_DRBG_RESEED, RAND_R_ERROR_RETRIEVING_ENTROPY); - goto end; - } - - if (!drbg->meth->reseed(drbg, entropy, entropylen, adin, adinlen)) - goto end; - - drbg->state = DRBG_READY; - drbg->reseed_gen_counter = 1; - drbg->reseed_time = time(NULL); - tsan_store(&drbg->reseed_prop_counter, drbg->reseed_next_counter); - - end: - if (entropy != NULL && drbg->cleanup_entropy != NULL) - drbg->cleanup_entropy(drbg, entropy, entropylen); - if (drbg->state == DRBG_READY) - return 1; - return 0; + return EVP_RAND_reseed(drbg->rand, prediction_resistance, NULL, 0, + adin, adinlen); } /* - * Restart |drbg|, using the specified entropy or additional input - * - * Tries its best to get the drbg instantiated by all means, - * regardless of its current state. + * Generate |outlen| bytes into the buffer at |out|. Reseed if we need + * to or if |prediction_resistance| is set. Additional input can be + * sent in |adin| and |adinlen|. * - * Optionally, a |buffer| of |len| random bytes can be passed, - * which is assumed to contain at least |entropy| bits of entropy. + * Requires that drbg->lock is already locked for write, if non-null. * - * If |entropy| > 0, the buffer content is used as entropy input. + * Returns 1 on success, 0 on failure. * - * If |entropy| == 0, the buffer content is used as additional input + */ +int RAND_DRBG_generate(RAND_DRBG *drbg, unsigned char *out, size_t outlen, + int prediction_resistance, + const unsigned char *adin, size_t adinlen) +{ + return EVP_RAND_generate(drbg->rand, out, outlen, 0, + prediction_resistance, adin, adinlen); +} + +/* + * Generates |outlen| random bytes and stores them in |out|. It will + * using the given |drbg| to generate the bytes. * - * Returns 1 on success, 0 on failure. + * Requires that drbg->lock is already locked for write, if non-null. * - * This function is used internally only. + * Returns 1 on success 0 on failure. */ -int rand_drbg_restart(RAND_DRBG *drbg, - const unsigned char *buffer, size_t len, size_t entropy) +int RAND_DRBG_bytes(RAND_DRBG *drbg, unsigned char *out, size_t outlen) { - int reseeded = 0; - const unsigned char *adin = NULL; - size_t adinlen = 0; - - if (drbg->seed_pool != NULL) { - RANDerr(RAND_F_RAND_DRBG_RESTART, ERR_R_INTERNAL_ERROR); - drbg->state = DRBG_ERROR; - rand_pool_free(drbg->seed_pool); - drbg->seed_pool = NULL; + return EVP_RAND_generate(drbg->rand, out, outlen, 0, 0, NULL, 0); +} + +/* DRBG call back shims */ +static int rand_drbg_get_entroy_cb(const OSSL_PARAM *params, OSSL_PARAM *out, + void *vdrbg) +{ + RAND_DRBG *drbg = (RAND_DRBG *)vdrbg; + int entropy = 0, prediction_resistance = 0; + size_t min_len = 0, max_len = 2048; + const OSSL_PARAM *p; + OSSL_PARAM *q; + + if (drbg->get_entropy == NULL) return 0; - } - if (buffer != NULL) { - if (entropy > 0) { - if (drbg->max_entropylen < len) { - RANDerr(RAND_F_RAND_DRBG_RESTART, - RAND_R_ENTROPY_INPUT_TOO_LONG); - drbg->state = DRBG_ERROR; - return 0; - } - - if (entropy > 8 * len) { - RANDerr(RAND_F_RAND_DRBG_RESTART, RAND_R_ENTROPY_OUT_OF_RANGE); - drbg->state = DRBG_ERROR; - return 0; - } - - /* will be picked up by the rand_drbg_get_entropy() callback */ - drbg->seed_pool = rand_pool_attach(buffer, len, entropy); - if (drbg->seed_pool == NULL) - return 0; - } else { - if (drbg->max_adinlen < len) { - RANDerr(RAND_F_RAND_DRBG_RESTART, - RAND_R_ADDITIONAL_INPUT_TOO_LONG); - drbg->state = DRBG_ERROR; - return 0; - } - adin = buffer; - adinlen = len; - } - } + p = OSSL_PARAM_locate_const(params, OSSL_DRBG_PARAM_ENTROPY_REQUIRED); + if (p == NULL || !OSSL_PARAM_get_int(p, &entropy)) + return 0; - /* repair error state */ - if (drbg->state == DRBG_ERROR) - RAND_DRBG_uninstantiate(drbg); - - /* repair uninitialized state */ - if (drbg->state == DRBG_UNINITIALISED) { - /* reinstantiate drbg */ - RAND_DRBG_instantiate(drbg, - (const unsigned char *) ossl_pers_string, - sizeof(ossl_pers_string) - 1); - /* already reseeded. prevent second reseeding below */ - reseeded = (drbg->state == DRBG_READY); - } + p = OSSL_PARAM_locate_const(params, OSSL_DRBG_PARAM_PREDICTION_RESISTANCE); + if (p == NULL || !OSSL_PARAM_get_int(p, &prediction_resistance)) + return 0; - /* refresh current state if entropy or additional input has been provided */ - if (drbg->state == DRBG_READY) { - if (adin != NULL) { - /* - * mix in additional input without reseeding - * - * Similar to RAND_DRBG_reseed(), but the provided additional - * data |adin| is mixed into the current state without pulling - * entropy from the trusted entropy source using get_entropy(). - * This is not a reseeding in the strict sense of NIST SP 800-90A. - */ - drbg->meth->reseed(drbg, adin, adinlen, NULL, 0); - } else if (reseeded == 0) { - /* do a full reseeding if it has not been done yet above */ - RAND_DRBG_reseed(drbg, NULL, 0, 0); - } - } + p = OSSL_PARAM_locate_const(params, OSSL_DRBG_PARAM_MAX_LENGTH); + if (p == NULL || !OSSL_PARAM_get_size_t(p, &max_len)) + return 0; - rand_pool_free(drbg->seed_pool); - drbg->seed_pool = NULL; + p = OSSL_PARAM_locate_const(params, OSSL_DRBG_PARAM_MIN_LENGTH); + if (p == NULL || !OSSL_PARAM_get_size_t(p, &min_len)) + return 0; + + q = OSSL_PARAM_locate(out, OSSL_DRBG_PARAM_RANDOM_DATA); + if (q == NULL || q->data_type != OSSL_PARAM_OCTET_PTR || q->data == NULL) + return 0; - return drbg->state == DRBG_READY; + q->return_size = drbg->get_entropy(drbg, (unsigned char **)q->data, entropy, + min_len, max_len, prediction_resistance); + return 1; } -/* - * Generate |outlen| bytes into the buffer at |out|. Reseed if we need - * to or if |prediction_resistance| is set. Additional input can be - * sent in |adin| and |adinlen|. - * - * Requires that drbg->lock is already locked for write, if non-null. - * - * Returns 1 on success, 0 on failure. - * - */ -int RAND_DRBG_generate(RAND_DRBG *drbg, unsigned char *out, size_t outlen, - int prediction_resistance, - const unsigned char *adin, size_t adinlen) +static int rand_drbg_cleanup_entropy_cb(const OSSL_PARAM *params, void *vdrbg) { - int fork_id; - int reseed_required = 0; - - if (drbg->state != DRBG_READY) { - /* try to recover from previous errors */ - rand_drbg_restart(drbg, NULL, 0, 0); - - if (drbg->state == DRBG_ERROR) { - RANDerr(RAND_F_RAND_DRBG_GENERATE, RAND_R_IN_ERROR_STATE); - return 0; - } - if (drbg->state == DRBG_UNINITIALISED) { - RANDerr(RAND_F_RAND_DRBG_GENERATE, RAND_R_NOT_INSTANTIATED); - return 0; - } - } + RAND_DRBG *drbg = (RAND_DRBG *)vdrbg; + const OSSL_PARAM *p; + size_t sz; - if (outlen > drbg->max_request) { - RANDerr(RAND_F_RAND_DRBG_GENERATE, RAND_R_REQUEST_TOO_LARGE_FOR_DRBG); + if (drbg->cleanup_entropy == NULL) return 0; - } - if (adinlen > drbg->max_adinlen) { - RANDerr(RAND_F_RAND_DRBG_GENERATE, RAND_R_ADDITIONAL_INPUT_TOO_LONG); + + p = OSSL_PARAM_locate_const(params, OSSL_DRBG_PARAM_SIZE); + if (p == NULL || !OSSL_PARAM_get_size_t(p, &sz)) return 0; - } - fork_id = openssl_get_fork_id(); + p = OSSL_PARAM_locate_const(params, OSSL_DRBG_PARAM_RANDOM_DATA); + if (p == NULL || p->data_type != OSSL_PARAM_OCTET_PTR) + return 0; - if (drbg->fork_id != fork_id) { - drbg->fork_id = fork_id; - reseed_required = 1; - } + drbg->cleanup_entropy(drbg, p->data, sz); + return 1; +} - if (drbg->reseed_interval > 0) { - if (drbg->reseed_gen_counter > drbg->reseed_interval) - reseed_required = 1; - } - if (drbg->reseed_time_interval > 0) { - time_t now = time(NULL); - if (now < drbg->reseed_time - || now - drbg->reseed_time >= drbg->reseed_time_interval) - reseed_required = 1; - } - if (drbg->parent != NULL) { - unsigned int reseed_counter = tsan_load(&drbg->reseed_prop_counter); - if (reseed_counter > 0 - && tsan_load(&drbg->parent->reseed_prop_counter) - != reseed_counter) - reseed_required = 1; - } +static int rand_drbg_get_nonce_cb(const OSSL_PARAM *params, OSSL_PARAM *out, + void *vdrbg) +{ + RAND_DRBG *drbg = (RAND_DRBG *)vdrbg; + int entropy = 0; + size_t min_len = 0, max_len = 10240; + const OSSL_PARAM *p; + OSSL_PARAM *q; - if (reseed_required || prediction_resistance) { - if (!RAND_DRBG_reseed(drbg, adin, adinlen, prediction_resistance)) { - RANDerr(RAND_F_RAND_DRBG_GENERATE, RAND_R_RESEED_ERROR); - return 0; - } - adin = NULL; - adinlen = 0; - } + if (drbg->get_nonce == NULL) + return 0; - if (!drbg->meth->generate(drbg, out, outlen, adin, adinlen)) { - drbg->state = DRBG_ERROR; - RANDerr(RAND_F_RAND_DRBG_GENERATE, RAND_R_GENERATE_ERROR); + p = OSSL_PARAM_locate_const(params, OSSL_DRBG_PARAM_ENTROPY_REQUIRED); + if (p == NULL || !OSSL_PARAM_get_int(p, &entropy)) return 0; - } - drbg->reseed_gen_counter++; + p = OSSL_PARAM_locate_const(params, OSSL_DRBG_PARAM_MAX_LENGTH); + if (p == NULL || !OSSL_PARAM_get_size_t(p, &max_len)) + return 0; + + p = OSSL_PARAM_locate_const(params, OSSL_DRBG_PARAM_MIN_LENGTH); + if (p == NULL || !OSSL_PARAM_get_size_t(p, &min_len)) + return 0; + + q = OSSL_PARAM_locate(out, OSSL_DRBG_PARAM_RANDOM_DATA); + if (q == NULL || q->data_type != OSSL_PARAM_OCTET_PTR || q->data == NULL) + return 0; + q->return_size = drbg->get_nonce(drbg, (unsigned char **)q->data, entropy, + min_len, max_len); return 1; } -/* - * Generates |outlen| random bytes and stores them in |out|. It will - * using the given |drbg| to generate the bytes. - * - * Requires that drbg->lock is already locked for write, if non-null. - * - * Returns 1 on success 0 on failure. - */ -int RAND_DRBG_bytes(RAND_DRBG *drbg, unsigned char *out, size_t outlen) +static int rand_drbg_cleanup_nonce_cb(const OSSL_PARAM *params, void *vdrbg) { - unsigned char *additional = NULL; - size_t additional_len; - size_t chunk; - size_t ret = 0; - - if (drbg->adin_pool == NULL) { - if (drbg->type == 0) - goto err; - drbg->adin_pool = rand_pool_new(0, 0, 0, drbg->max_adinlen); - if (drbg->adin_pool == NULL) - goto err; - } + RAND_DRBG *drbg = (RAND_DRBG *)vdrbg; + const OSSL_PARAM *p; + size_t sz; - additional_len = rand_drbg_get_additional_data(drbg->adin_pool, - &additional); + if (drbg->cleanup_nonce == NULL) + return 0; - for ( ; outlen > 0; outlen -= chunk, out += chunk) { - chunk = outlen; - if (chunk > drbg->max_request) - chunk = drbg->max_request; - ret = RAND_DRBG_generate(drbg, out, chunk, 0, additional, additional_len); - if (!ret) - goto err; - } - ret = 1; + p = OSSL_PARAM_locate_const(params, OSSL_DRBG_PARAM_SIZE); + if (p == NULL || !OSSL_PARAM_get_size_t(p, &sz)) + return 0; - err: - if (additional != NULL) - rand_drbg_cleanup_additional_data(drbg->adin_pool, additional); + p = OSSL_PARAM_locate_const(params, OSSL_DRBG_PARAM_RANDOM_DATA); + if (p == NULL || p->data_type != OSSL_PARAM_OCTET_PTR) + return 0; - return ret; + drbg->cleanup_nonce(drbg, p->data, sz); + return 1; } /* @@ -999,13 +656,25 @@ int RAND_DRBG_set_callbacks(RAND_DRBG *drbg, RAND_DRBG_get_nonce_fn get_nonce, RAND_DRBG_cleanup_nonce_fn cleanup_nonce) { - if (drbg->state != DRBG_UNINITIALISED - || drbg->parent != NULL) + EVP_RAND_CTX *rand = drbg->rand; + OSSL_INOUT_CALLBACK *g_ent = NULL, *g_nonce = NULL; + OSSL_CALLBACK *c_ent = NULL, *c_nonce = NULL; + + if (get_entropy != NULL) { + g_ent = &rand_drbg_get_entroy_cb; + c_ent = &rand_drbg_cleanup_entropy_cb; + } + if (get_nonce != NULL) { + g_nonce = rand_drbg_get_nonce_cb; + c_nonce = rand_drbg_cleanup_nonce_cb; + } + if (!EVP_RAND_set_callbacks(rand, g_ent, c_ent, g_nonce, c_nonce, drbg)) return 0; - drbg->get_entropy = get_entropy; - drbg->cleanup_entropy = cleanup_entropy; - drbg->get_nonce = get_nonce; - drbg->cleanup_nonce = cleanup_nonce; + + drbg->get_entropy = g_ent != NULL ? get_entropy : NULL; + drbg->cleanup_entropy = c_ent != NULL ? cleanup_entropy : NULL; + drbg->get_nonce = g_nonce != NULL ? get_nonce : NULL; + drbg->cleanup_nonce = c_nonce != NULL ? cleanup_nonce : NULL; return 1; } @@ -1020,10 +689,13 @@ int RAND_DRBG_set_callbacks(RAND_DRBG *drbg, */ int RAND_DRBG_set_reseed_interval(RAND_DRBG *drbg, unsigned int interval) { + OSSL_PARAM params[2] = { OSSL_PARAM_END, OSSL_PARAM_END }; + if (interval > MAX_RESEED_INTERVAL) return 0; - drbg->reseed_interval = interval; - return 1; + params[0] = OSSL_PARAM_construct_uint(OSSL_DRBG_PARAM_RESEED_REQUESTS, + &interval); + return EVP_RAND_set_ctx_params(drbg->rand, params); } /* @@ -1038,10 +710,14 @@ int RAND_DRBG_set_reseed_interval(RAND_DRBG *drbg, unsigned int interval) */ int RAND_DRBG_set_reseed_time_interval(RAND_DRBG *drbg, time_t interval) { + OSSL_PARAM params[2] = { OSSL_PARAM_END, OSSL_PARAM_END }; + if (interval > MAX_RESEED_TIME_INTERVAL) return 0; - drbg->reseed_time_interval = interval; - return 1; + params[0] = + OSSL_PARAM_construct_time_t(OSSL_DRBG_PARAM_RESEED_TIME_INTERVAL, + &interval); + return EVP_RAND_set_ctx_params(drbg->rand, params); } /* @@ -1077,69 +753,6 @@ int RAND_DRBG_set_reseed_defaults( return 1; } -/* - * Locks the given drbg. Locking a drbg which does not have locking - * enabled is considered a successful no-op. - * - * Returns 1 on success, 0 on failure. - */ -int rand_drbg_lock(RAND_DRBG *drbg) -{ - if (drbg->lock != NULL) - return CRYPTO_THREAD_write_lock(drbg->lock); - - return 1; -} - -/* - * Unlocks the given drbg. Unlocking a drbg which does not have locking - * enabled is considered a successful no-op. - * - * Returns 1 on success, 0 on failure. - */ -int rand_drbg_unlock(RAND_DRBG *drbg) -{ - if (drbg->lock != NULL) - return CRYPTO_THREAD_unlock(drbg->lock); - - return 1; -} - -/* - * Enables locking for the given drbg - * - * Locking can only be enabled if the random generator - * is in the uninitialized state. - * - * Returns 1 on success, 0 on failure. - */ -int rand_drbg_enable_locking(RAND_DRBG *drbg) -{ - if (drbg->state != DRBG_UNINITIALISED) { - RANDerr(RAND_F_RAND_DRBG_ENABLE_LOCKING, - RAND_R_DRBG_ALREADY_INITIALIZED); - return 0; - } - - if (drbg->lock == NULL) { - if (drbg->parent != NULL && drbg->parent->lock == NULL) { - RANDerr(RAND_F_RAND_DRBG_ENABLE_LOCKING, - RAND_R_PARENT_LOCKING_NOT_ENABLED); - return 0; - } - - drbg->lock = CRYPTO_THREAD_lock_new(); - if (drbg->lock == NULL) { - RANDerr(RAND_F_RAND_DRBG_ENABLE_LOCKING, - RAND_R_FAILED_TO_CREATE_LOCK); - return 0; - } - } - - return 1; -} - -#ifndef FIPS_MODULE /* * Get and set the EXDATA */ @@ -1152,7 +765,6 @@ void *RAND_DRBG_get_ex_data(const RAND_DRBG *drbg, int idx) { return CRYPTO_get_ex_data(&drbg->ex_data, idx); } -#endif /* * The following functions provide a RAND_METHOD that works on the @@ -1169,27 +781,22 @@ static RAND_DRBG *drbg_setup(OPENSSL_CTX *ctx, RAND_DRBG *parent, int drbg_type) { RAND_DRBG *drbg; - drbg = RAND_DRBG_secure_new_ex(ctx, rand_drbg_type[drbg_type], - rand_drbg_flags[drbg_type], parent); + drbg = RAND_DRBG_new_ex(ctx, rand_drbg_type[drbg_type], + rand_drbg_flags[drbg_type], parent); if (drbg == NULL) return NULL; /* Only the master DRBG needs to have a lock */ - if (parent == NULL && rand_drbg_enable_locking(drbg) == 0) + if (parent == NULL && EVP_RAND_enable_locking(drbg->rand) == 0) goto err; - /* enable seed propagation */ - tsan_store(&drbg->reseed_prop_counter, 1); - /* * Ignore instantiation error to support just-in-time instantiation. * * The state of the drbg will be checked in RAND_DRBG_generate() and * an automatic recovery is attempted. */ - (void)RAND_DRBG_instantiate(drbg, - (const unsigned char *) ossl_pers_string, - sizeof(ossl_pers_string) - 1); + (void)RAND_DRBG_instantiate(drbg, NULL, 0); return drbg; err: @@ -1228,112 +835,15 @@ static int drbg_bytes(unsigned char *out, int count) return ret; } -/* - * Calculates the minimum length of a full entropy buffer - * which is necessary to seed (i.e. instantiate) the DRBG - * successfully. - */ -size_t rand_drbg_seedlen(RAND_DRBG *drbg) -{ - /* - * If no os entropy source is available then RAND_seed(buffer, bufsize) - * is expected to succeed if and only if the buffer length satisfies - * the following requirements, which follow from the calculations - * in RAND_DRBG_instantiate(). - */ - size_t min_entropy = drbg->strength; - size_t min_entropylen = drbg->min_entropylen; - - /* - * Extra entropy for the random nonce in the absence of a - * get_nonce callback, see comment in RAND_DRBG_instantiate(). - */ - if (drbg->min_noncelen > 0 && drbg->get_nonce == NULL) { - min_entropy += drbg->strength / 2; - min_entropylen += drbg->min_noncelen; - } - - /* - * Convert entropy requirement from bits to bytes - * (dividing by 8 without rounding upwards, because - * all entropy requirements are divisible by 8). - */ - min_entropy >>= 3; - - /* Return a value that satisfies both requirements */ - return min_entropy > min_entropylen ? min_entropy : min_entropylen; -} - /* Implements the default OpenSSL RAND_add() method */ static int drbg_add(const void *buf, int num, double randomness) { - int ret = 0; RAND_DRBG *drbg = RAND_DRBG_get0_master(); - size_t buflen; - size_t seedlen; - if (drbg == NULL) + if (drbg == NULL || num <= 0) return 0; - if (num < 0 || randomness < 0.0) - return 0; - - rand_drbg_lock(drbg); - seedlen = rand_drbg_seedlen(drbg); - - buflen = (size_t)num; - -#ifdef FIPS_MODULE - /* - * NIST SP-800-90A mandates that entropy *shall not* be provided - * by the consuming application. By setting the randomness to zero, - * we ensure that the buffer contents will be added to the internal - * state of the DRBG only as additional data. - * - * (NIST SP-800-90Ar1, Sections 9.1 and 9.2) - */ - randomness = 0.0; -#endif - if (buflen < seedlen || randomness < (double) seedlen) { -#if defined(OPENSSL_RAND_SEED_NONE) - /* - * If no os entropy source is available, a reseeding will fail - * inevitably. So we use a trick to mix the buffer contents into - * the DRBG state without forcing a reseeding: we generate a - * dummy random byte, using the buffer content as additional data. - * Note: This won't work with RAND_DRBG_FLAG_CTR_NO_DF. - */ - unsigned char dummy[1]; - - ret = RAND_DRBG_generate(drbg, dummy, sizeof(dummy), 0, buf, buflen); - rand_drbg_unlock(drbg); - return ret; -#else - /* - * If an os entropy source is available then we declare the buffer content - * as additional data by setting randomness to zero and trigger a regular - * reseeding. - */ - randomness = 0.0; -#endif - } - - if (randomness > (double)seedlen) { - /* - * The purpose of this check is to bound |randomness| by a - * relatively small value in order to prevent an integer - * overflow when multiplying by 8 in the rand_drbg_restart() - * call below. Note that randomness is measured in bytes, - * not bits, so this value corresponds to eight times the - * security strength. - */ - randomness = (double)seedlen; - } - - ret = rand_drbg_restart(drbg, buf, buflen, (size_t)(8 * randomness)); - rand_drbg_unlock(drbg); - - return ret; + return EVP_RAND_reseed(drbg->rand, 0, NULL, 0, buf, num); } /* Implements the default OpenSSL RAND_seed() method */ @@ -1351,12 +861,15 @@ static int drbg_status(void) if (drbg == NULL) return 0; - rand_drbg_lock(drbg); - ret = drbg->state == DRBG_READY ? 1 : 0; - rand_drbg_unlock(drbg); + ret = EVP_RAND_state(drbg->rand) == EVP_RAND_STATE_READY ? 1 : 0; return ret; } +int RAND_DRBG_verify_zeroization(RAND_DRBG *drbg) +{ + return EVP_RAND_verify_zeroization(drbg->rand); +} + /* * Get the master DRBG. * Returns pointer to the DRBG on success, NULL on failure. @@ -1369,6 +882,13 @@ RAND_DRBG *OPENSSL_CTX_get0_master_drbg(OPENSSL_CTX *ctx) if (dgbl == NULL) return NULL; + if (dgbl->master_drbg == NULL) { + if (!CRYPTO_THREAD_write_lock(dgbl->lock)) + return NULL; + if (dgbl->master_drbg == NULL) + dgbl->master_drbg = drbg_setup(ctx, NULL, RAND_DRBG_TYPE_MASTER); + CRYPTO_THREAD_unlock(dgbl->lock); + } return dgbl->master_drbg; } @@ -1384,13 +904,17 @@ RAND_DRBG *RAND_DRBG_get0_master(void) RAND_DRBG *OPENSSL_CTX_get0_public_drbg(OPENSSL_CTX *ctx) { DRBG_GLOBAL *dgbl = drbg_get_global(ctx); - RAND_DRBG *drbg; + RAND_DRBG *drbg, *master; if (dgbl == NULL) return NULL; drbg = CRYPTO_THREAD_get_local(&dgbl->public_drbg); if (drbg == NULL) { + master = OPENSSL_CTX_get0_master_drbg(ctx); + if (master == NULL) + return NULL; + ctx = openssl_ctx_get_concrete(ctx); /* * If the private_drbg is also NULL then this is the first time we've @@ -1399,7 +923,7 @@ RAND_DRBG *OPENSSL_CTX_get0_public_drbg(OPENSSL_CTX *ctx) if (CRYPTO_THREAD_get_local(&dgbl->private_drbg) == NULL && !ossl_init_thread_start(NULL, ctx, drbg_delete_thread_state)) return NULL; - drbg = drbg_setup(ctx, dgbl->master_drbg, RAND_DRBG_TYPE_PUBLIC); + drbg = drbg_setup(ctx, master, RAND_DRBG_TYPE_PUBLIC); CRYPTO_THREAD_set_local(&dgbl->public_drbg, drbg); } return drbg; @@ -1417,13 +941,17 @@ RAND_DRBG *RAND_DRBG_get0_public(void) RAND_DRBG *OPENSSL_CTX_get0_private_drbg(OPENSSL_CTX *ctx) { DRBG_GLOBAL *dgbl = drbg_get_global(ctx); - RAND_DRBG *drbg; + RAND_DRBG *drbg, *master; if (dgbl == NULL) return NULL; drbg = CRYPTO_THREAD_get_local(&dgbl->private_drbg); if (drbg == NULL) { + master = OPENSSL_CTX_get0_master_drbg(ctx); + if (master == NULL) + return NULL; + ctx = openssl_ctx_get_concrete(ctx); /* * If the public_drbg is also NULL then this is the first time we've @@ -1432,7 +960,7 @@ RAND_DRBG *OPENSSL_CTX_get0_private_drbg(OPENSSL_CTX *ctx) if (CRYPTO_THREAD_get_local(&dgbl->public_drbg) == NULL && !ossl_init_thread_start(NULL, ctx, drbg_delete_thread_state)) return NULL; - drbg = drbg_setup(ctx, dgbl->master_drbg, RAND_DRBG_TYPE_PRIVATE); + drbg = drbg_setup(ctx, master, RAND_DRBG_TYPE_PRIVATE); CRYPTO_THREAD_set_local(&dgbl->private_drbg, drbg); } return drbg;