test/uitest.c's pem_password_cb returned 1 instead of the password length

[openssl.git] / test / uitest.c

diff --git a/test/uitest.c b/test/uitest.c
index 84fe71b22d5fca7ef1d66dfe7eb299d33469efe7..469e2304f8b31f9057675ccc5746d321c32e9b2e 100644 (file)
--- a/test/uitest.c
+++ b/test/uitest.c
@@ -9,22 +9,22 @@
 
 #include <stdio.h>
 #include <string.h>
+#include <openssl/opensslconf.h>
 #include <openssl/err.h>
-#include <openssl/ui.h>
-#include "../apps/apps.h"
-
+#include "apps.h"
 #include "testutil.h"
-#include "test_main_custom.h"
 
 /* apps/apps.c depend on these */
 char *default_config_file = NULL;
-BIO *bio_err = NULL;
+
+#ifndef OPENSSL_NO_UI
+# include <openssl/ui.h>
 
 /* Old style PEM password callback */
 static int test_pem_password_cb(char *buf, int size, int rwflag, void *userdata)
 {
     OPENSSL_strlcpy(buf, (char *)userdata, (size_t)size);
-    return 1;
+    return strlen(buf);
 }
 
 /*
@@ -39,9 +39,9 @@ static int test_old()
     char pass[16];
     int ok = 0;
 
-    if ((ui_method =
-         UI_UTIL_wrap_read_pem_callback(test_pem_password_cb, 0)) == NULL
-        || (ui = UI_new_method(ui_method)) == NULL)
+    if (!TEST_ptr(ui_method =
+                  UI_UTIL_wrap_read_pem_callback( test_pem_password_cb, 0))
+            || !TEST_ptr(ui = UI_new_method(ui_method)))
         goto err;
 
     /* The wrapper passes the UI userdata as the callback userdata param */
@@ -53,7 +53,7 @@ static int test_old()
 
     switch (UI_process(ui)) {
     case -2:
-        BIO_printf(bio_err, "test_old: UI process interrupted or cancelled\n");
+        TEST_info("test_old: UI process interrupted or cancelled");
         /* fall through */
     case -1:
         goto err;
@@ -61,14 +61,10 @@ static int test_old()
         break;
     }
 
-    if (strcmp(pass, defpass) == 0)
+    if (TEST_str_eq(pass, defpass))
         ok = 1;
-    else
-        BIO_printf(bio_err, "test_old: password failure\n");
 
  err:
-    if (!ok)
-        ERR_print_errors_fp(stderr);
     UI_free(ui);
     UI_destroy_method(ui_method);
 
@@ -86,32 +82,19 @@ static int test_new_ui()
     int ok = 0;
 
     setup_ui_method();
-    if (password_callback(pass, sizeof(pass), 0, &cb_data) > 0
-        && strcmp(pass, cb_data.password) == 0)
+    if (TEST_int_gt(password_callback(pass, sizeof(pass), 0, &cb_data), 0)
+            && TEST_str_eq(pass, cb_data.password))
         ok = 1;
-    else
-        BIO_printf(bio_err, "test_new: password failure\n");
-
-    if (!ok)
-        ERR_print_errors_fp(stderr);
-
     destroy_ui_method();
     return ok;
 }
 
-int test_main(int argc, char *argv[])
-{
-    int ret;
-
-    bio_err = dup_bio_err(FORMAT_TEXT);
+#endif
 
+void register_tests(void)
+{
+#ifndef OPENSSL_NO_UI
     ADD_TEST(test_old);
     ADD_TEST(test_new_ui);
-
-    ret = run_tests(argv[0]);
-
-    (void)BIO_flush(bio_err);
-    BIO_free(bio_err);
-
-    return ret;
+#endif
 }