*/
#include <ctype.h>
+#include <math.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <openssl/x509.h>
#include <openssl/x509v3.h>
#include "testutil.h"
+#include "test_main_custom.h"
#ifndef OPENSSL_NO_CT
-
/* Used when declaring buffers to read text files into */
#define CT_TEST_MAX_FILE_SIZE 8096
typedef struct ct_test_fixture {
const char *test_case_name;
+ /* The current time in milliseconds */
+ uint64_t epoch_time_in_ms;
/* The CT log store to use during tests */
CTLOG_STORE* ctlog_store;
/* Set the following to test handling of SCTs in X509 certificates */
const char *certs_dir;
char *certificate_file;
char *issuer_file;
+ /* Expected number of SCTs */
int expected_sct_count;
+ /* Expected number of valid SCTS */
+ int expected_valid_sct_count;
/* Set the following to test handling of SCTs in TLS format */
const unsigned char *tls_sct_list;
size_t tls_sct_list_len;
const char *sct_text_file;
/* Whether to test the validity of the SCT(s) */
int test_validity;
-
} CT_TEST_FIXTURE;
static CT_TEST_FIXTURE set_up(const char *const test_case_name)
{
CT_TEST_FIXTURE fixture;
- int setup_ok = 1;
- CTLOG_STORE *ctlog_store;
+ int ok = 0;
memset(&fixture, 0, sizeof(fixture));
-
- ctlog_store = CTLOG_STORE_new();
-
- if (ctlog_store == NULL) {
- setup_ok = 0;
- fprintf(stderr, "Failed to create a new CT log store\n");
- goto end;
- }
-
- if (CTLOG_STORE_load_default_file(ctlog_store) != 1) {
- setup_ok = 0;
- fprintf(stderr, "Failed to load CT log list\n");
- goto end;
- }
-
fixture.test_case_name = test_case_name;
- fixture.ctlog_store = ctlog_store;
+ fixture.epoch_time_in_ms = 1473269626000; /* Sep 7 17:33:46 2016 GMT */
+ if (!TEST_ptr(fixture.ctlog_store = CTLOG_STORE_new())
+ || !TEST_int_eq(
+ CTLOG_STORE_load_default_file(fixture.ctlog_store), 1))
+ goto end;
+ ok = 1;
end:
- if (!setup_ok) {
+ if (!ok) {
+ CTLOG_STORE_free(fixture.ctlog_store);
+ TEST_error("Failed to setup");
exit(EXIT_FAILURE);
}
return fixture;
{
CTLOG_STORE_free(fixture.ctlog_store);
SCT_LIST_free(fixture.sct_list);
- ERR_print_errors_fp(stderr);
}
static char *mk_file_path(const char *dir, const char *file)
{
- char *full_file = NULL;
- size_t full_file_l = 0;
- const char *sep = "";
#ifndef OPENSSL_SYS_VMS
- sep = "/";
+ const char *sep = "/";
+#else
+ const char *sep = "";
#endif
+ size_t len = strlen(dir) + strlen(sep) + strlen(file) + 1;
+ char *full_file = OPENSSL_zalloc(len);
- full_file_l = strlen(dir) + strlen(sep) + strlen(file) + 1;
- full_file = OPENSSL_zalloc(full_file_l);
if (full_file != NULL) {
- OPENSSL_strlcpy(full_file, dir, full_file_l);
- OPENSSL_strlcat(full_file, sep, full_file_l);
- OPENSSL_strlcat(full_file, file, full_file_l);
+ OPENSSL_strlcpy(full_file, dir, len);
+ OPENSSL_strlcat(full_file, sep, len);
+ OPENSSL_strlcat(full_file, file, len);
}
return full_file;
if (file_path != NULL) {
BIO *cert_io = BIO_new_file(file_path, "r");
- OPENSSL_free(file_path);
if (cert_io != NULL)
cert = PEM_read_bio_X509(cert_io, NULL, NULL, NULL);
-
BIO_free(cert_io);
}
+
+ OPENSSL_free(file_path);
return cert;
}
static int read_text_file(const char *dir, const char *file,
char *buffer, int buffer_length)
{
- int result = -1;
+ int len = -1;
char *file_path = mk_file_path(dir, file);
if (file_path != NULL) {
BIO *file_io = BIO_new_file(file_path, "r");
- OPENSSL_free(file_path);
- if (file_io != NULL) {
- result = BIO_read(file_io, buffer, buffer_length);
- BIO_free(file_io);
- }
+ if (file_io != NULL)
+ len = BIO_read(file_io, buffer, buffer_length);
+ BIO_free(file_io);
}
- return result;
+ OPENSSL_free(file_path);
+ return len;
}
static int compare_sct_list_printout(STACK_OF(SCT) *sct,
- const char *expected_output)
+ const char *expected_output)
{
BIO *text_buffer = NULL;
char *actual_output = NULL;
- int result = 1;
+ int result = 0;
- text_buffer = BIO_new(BIO_s_mem());
- if (text_buffer == NULL) {
- fprintf(stderr, "Unable to allocate buffer\n");
+ if (!TEST_ptr(text_buffer = BIO_new(BIO_s_mem())))
goto end;
- }
SCT_LIST_print(sct, text_buffer, 0, "\n", NULL);
- /* Append null terminator because we're about to use the buffer contents
- * as a string. */
- if (BIO_write(text_buffer, "\0", 1) != 1) {
- fprintf(stderr, "Failed to append null terminator to SCT text\n");
+ /* Append \0 because we're about to use the buffer contents as a string. */
+ if (!TEST_true(BIO_write(text_buffer, "\0", 1)))
goto end;
- }
BIO_get_mem_data(text_buffer, &actual_output);
- result = strcmp(actual_output, expected_output);
-
- if (result != 0) {
- fprintf(stderr,
- "Expected SCT printout:\n%s\nActual SCT printout:\n%s\n",
- expected_output, actual_output);
- }
+ if (!TEST_str_eq(actual_output, expected_output))
+ goto end;
+ result = 1;
end:
BIO_free(text_buffer);
{
BIO *text_buffer = NULL;
char *actual_output = NULL;
- int result = 1;
-
- text_buffer = BIO_new(BIO_s_mem());
- if (text_buffer == NULL) {
- fprintf(stderr, "Unable to allocate buffer\n");
- goto end;
- }
+ int result = 0;
- if (!X509V3_EXT_print(text_buffer, extension, X509V3_EXT_DEFAULT, 0)) {
- fprintf(stderr, "Failed to print extension\n");
+ if (!TEST_ptr(text_buffer = BIO_new(BIO_s_mem()))
+ || !TEST_true(X509V3_EXT_print(text_buffer, extension,
+ X509V3_EXT_DEFAULT, 0)))
goto end;
- }
- /* Append null terminator because we're about to use the buffer contents
- * as a string. */
- if (BIO_write(text_buffer, "\0", 1) != 1) {
- fprintf(stderr,
- "Failed to append null terminator to extension text\n");
+ /* Append \0 because we're about to use the buffer contents as a string. */
+ if (!TEST_true(BIO_write(text_buffer, "\0", 1)))
goto end;
- }
BIO_get_mem_data(text_buffer, &actual_output);
- result = strcmp(actual_output, expected_output);
+ if (!TEST_str_eq(actual_output, expected_output))
+ goto end;
- if (result != 0) {
- fprintf(stderr,
- "Expected SCT printout:\n%s\nActual SCT printout:\n%s\n",
- expected_output, actual_output);
- }
+ result = 1;
end:
BIO_free(text_buffer);
return result;
}
-static int assert_validity(CT_TEST_FIXTURE fixture,
- STACK_OF(SCT) *scts,
- CT_POLICY_EVAL_CTX *policy_ctx) {
+static int assert_validity(CT_TEST_FIXTURE fixture, STACK_OF(SCT) *scts,
+ CT_POLICY_EVAL_CTX *policy_ctx)
+{
int invalid_sct_count = 0;
int valid_sct_count = 0;
int i;
- if (SCT_LIST_validate(scts, policy_ctx) < 0) {
- fprintf(stderr, "Error verifying SCTs\n");
+ if (!TEST_int_ge(SCT_LIST_validate(scts, policy_ctx), 0))
return 0;
- }
for (i = 0; i < sk_SCT_num(scts); ++i) {
SCT *sct_i = sk_SCT_value(scts, i);
+
switch (SCT_get_validation_status(sct_i)) {
case SCT_VALIDATION_STATUS_VALID:
++valid_sct_count;
case SCT_VALIDATION_STATUS_INVALID:
++invalid_sct_count;
break;
- default:
+ case SCT_VALIDATION_STATUS_NOT_SET:
+ case SCT_VALIDATION_STATUS_UNKNOWN_LOG:
+ case SCT_VALIDATION_STATUS_UNVERIFIED:
+ case SCT_VALIDATION_STATUS_UNKNOWN_VERSION:
/* Ignore other validation statuses. */
break;
}
}
- if (valid_sct_count != fixture.expected_sct_count) {
+ if (!TEST_int_eq(valid_sct_count, fixture.expected_valid_sct_count)) {
int unverified_sct_count = sk_SCT_num(scts) -
- invalid_sct_count - valid_sct_count;
-
- fprintf(stderr,
- "%d SCTs failed verification\n"
- "%d SCTs passed verification (%d expected)\n"
- "%d SCTs were unverified\n",
- invalid_sct_count,
- valid_sct_count,
- fixture.expected_sct_count,
- unverified_sct_count);
+ invalid_sct_count - valid_sct_count;
+
+ TEST_info("%d SCTs failed, %d SCTs unverified",
+ invalid_sct_count, unverified_sct_count);
return 0;
}
expected_sct_text,
CT_TEST_MAX_FILE_SIZE - 1);
- if (sct_text_len < 0) {
- fprintf(stderr, "Test data file not found: %s\n",
- fixture.sct_text_file);
+ if (!TEST_int_ge(sct_text_len, 0))
goto end;
- }
-
expected_sct_text[sct_text_len] = '\0';
}
- CT_POLICY_EVAL_CTX_set0_log_store(ct_policy_ctx, fixture.ctlog_store);
+ CT_POLICY_EVAL_CTX_set_shared_CTLOG_STORE(
+ ct_policy_ctx, fixture.ctlog_store);
+
+ CT_POLICY_EVAL_CTX_set_time(ct_policy_ctx, fixture.epoch_time_in_ms);
if (fixture.certificate_file != NULL) {
int sct_extension_index;
X509_EXTENSION *sct_extension = NULL;
- cert = load_pem_cert(fixture.certs_dir, fixture.certificate_file);
- if (cert == NULL) {
- fprintf(stderr, "Unable to load certificate: %s\n",
- fixture.certificate_file);
+ if (!TEST_ptr(cert = load_pem_cert(fixture.certs_dir,
+ fixture.certificate_file)))
goto end;
- }
- CT_POLICY_EVAL_CTX_set0_cert(ct_policy_ctx, cert);
+ CT_POLICY_EVAL_CTX_set1_cert(ct_policy_ctx, cert);
if (fixture.issuer_file != NULL) {
- issuer = load_pem_cert(fixture.certs_dir, fixture.issuer_file);
-
- if (issuer == NULL) {
- fprintf(stderr, "Unable to load issuer certificate: %s\n",
- fixture.issuer_file);
+ if (!TEST_ptr(issuer = load_pem_cert(fixture.certs_dir,
+ fixture.issuer_file)))
goto end;
- }
-
- CT_POLICY_EVAL_CTX_set0_issuer(ct_policy_ctx, issuer);
+ CT_POLICY_EVAL_CTX_set1_issuer(ct_policy_ctx, issuer);
}
sct_extension_index =
X509_get_ext_by_NID(cert, NID_ct_precert_scts, -1);
sct_extension = X509_get_ext(cert, sct_extension_index);
if (fixture.expected_sct_count > 0) {
- if (sct_extension == NULL) {
- fprintf(stderr, "SCT extension not found in: %s\n",
- fixture.certificate_file);
+ if (!TEST_ptr(sct_extension))
goto end;
- }
if (fixture.sct_text_file
- && compare_extension_printout(sct_extension,
- expected_sct_text)) {
+ && !compare_extension_printout(sct_extension,
+ expected_sct_text))
goto end;
- }
if (fixture.test_validity) {
int i;
for (i = 0; i < sk_SCT_num(scts); ++i) {
SCT *sct_i = sk_SCT_value(scts, i);
- if (!SCT_set_source(sct_i, SCT_SOURCE_X509V3_EXTENSION)) {
- fprintf(stderr,
- "Error setting SCT source to X509v3 extension\n");
+ if (!TEST_true(SCT_set_source(sct_i,
+ SCT_SOURCE_X509V3_EXTENSION)))
goto end;
- }
}
if (!assert_validity(fixture, scts, ct_policy_ctx))
goto end;
}
- } else if (sct_extension != NULL) {
- fprintf(stderr,
- "Expected no SCTs, but found SCT extension in: %s\n",
- fixture.certificate_file);
+ } else if (!TEST_ptr_null(sct_extension)) {
goto end;
}
}
if (fixture.tls_sct_list != NULL) {
const unsigned char *p = fixture.tls_sct_list;
- if (o2i_SCT_LIST(&scts, &p, fixture.tls_sct_list_len) == NULL) {
- fprintf(stderr, "Failed to decode SCTs from TLS format\n");
+
+ if (!TEST_ptr(o2i_SCT_LIST(&scts, &p, fixture.tls_sct_list_len)))
goto end;
- }
if (fixture.test_validity && cert != NULL) {
if (!assert_validity(fixture, scts, ct_policy_ctx))
}
if (fixture.sct_text_file
- && compare_sct_list_printout(scts, expected_sct_text)) {
+ && !compare_sct_list_printout(scts, expected_sct_text)) {
goto end;
}
tls_sct_list_len = i2o_SCT_LIST(scts, &tls_sct_list);
- if (tls_sct_list_len != fixture.tls_sct_list_len ||
- memcmp(fixture.tls_sct_list, tls_sct_list, tls_sct_list_len) != 0) {
- fprintf(stderr,
- "Failed to encode SCTs into TLS format correctly\n");
+ if (!TEST_mem_eq(fixture.tls_sct_list, fixture.tls_sct_list_len,
+ tls_sct_list, tls_sct_list_len))
goto end;
- }
}
success = 1;
fixture.certs_dir = certs_dir;
fixture.certificate_file = "embeddedSCTs1.pem";
fixture.issuer_file = "embeddedSCTs1_issuer.pem";
- fixture.expected_sct_count = 1;
+ fixture.expected_sct_count = fixture.expected_valid_sct_count = 1;
fixture.test_validity = 1;
EXECUTE_CT_TEST();
}
fixture.certs_dir = certs_dir;
fixture.certificate_file = "embeddedSCTs3.pem";
fixture.issuer_file = "embeddedSCTs3_issuer.pem";
- fixture.expected_sct_count = 3;
+ fixture.expected_sct_count = fixture.expected_valid_sct_count = 3;
+ fixture.test_validity = 1;
+ EXECUTE_CT_TEST();
+}
+
+static int test_verify_fails_for_future_sct()
+{
+ SETUP_CT_TEST_FIXTURE();
+ fixture.epoch_time_in_ms = 1365094800000; /* Apr 4 17:00:00 2013 GMT */
+ fixture.certs_dir = certs_dir;
+ fixture.certificate_file = "embeddedSCTs1.pem";
+ fixture.issuer_file = "embeddedSCTs1_issuer.pem";
+ fixture.expected_sct_count = 1;
+ fixture.expected_valid_sct_count = 0;
fixture.test_validity = 1;
EXECUTE_CT_TEST();
}
static int test_encode_tls_sct()
{
- const unsigned char log_id[] = "\xDF\x1C\x2E\xC1\x15\x00\x94\x52\x47\xA9"
- "\x61\x68\x32\x5D\xDC\x5C\x79\x59\xE8\xF7\xC6\xD3\x88\xFC\x00\x2E"
- "\x0B\xBD\x3F\x74\xD7\x64";
-
- const unsigned char signature[] = "\x45\x02\x20\x48\x2F\x67\x51\xAF\x35"
- "\xDB\xA6\x54\x36\xBE\x1F\xD6\x64\x0F\x3D\xBF\x9A\x41\x42\x94\x95"
- "\x92\x45\x30\x28\x8F\xA3\xE5\xE2\x3E\x06\x02\x21\x00\xE4\xED\xC0"
- "\xDB\x3A\xC5\x72\xB1\xE2\xF5\xE8\xAB\x6A\x68\x06\x53\x98\x7D\xCF"
- "\x41\x02\x7D\xFE\xFF\xA1\x05\x51\x9D\x89\xED\xBF\x08";
+ const char log_id[] = "3xwuwRUAlFJHqWFoMl3cXHlZ6PfG04j8AC4LvT9012Q=";
+ const uint64_t timestamp = 1;
+ const char extensions[] = "";
+ const char signature[] = "BAMARzBAMiBIL2dRrzXbplQ2vh/WZA89v5pBQpSVkkUwKI+j5"
+ "eI+BgIhAOTtwNs6xXKx4vXoq2poBlOYfc9BAn3+/6EFUZ2J7b8I";
+ SCT *sct = NULL;
SETUP_CT_TEST_FIXTURE();
- STACK_OF(SCT) *sct_list = sk_SCT_new_null();
- SCT *sct = SCT_new();
- if (!SCT_set_version(sct, SCT_VERSION_V1)) {
- fprintf(stderr, "Failed to set SCT version\n");
- return 1;
- }
- if (!SCT_set1_log_id(sct, log_id, 32)) {
- fprintf(stderr, "Failed to set SCT log ID\n");
- return 1;
- }
- SCT_set_timestamp(sct, 1);
- if (!SCT_set_signature_nid(sct, NID_ecdsa_with_SHA256)) {
- fprintf(stderr, "Failed to set SCT signature NID\n");
- return 1;
- }
- if (!SCT_set1_signature(sct, signature, 71)) {
- fprintf(stderr, "Failed to set SCT signature\n");
- return 1;
- }
- sk_SCT_push(sct_list, sct);
+ fixture.sct_list = sk_SCT_new_null();
+ if (!TEST_ptr(sct = SCT_new_from_base64(SCT_VERSION_V1, log_id,
+ CT_LOG_ENTRY_TYPE_X509, timestamp,
+ extensions, signature)))
+
+ return 0;
- fixture.sct_list = sct_list;
+ sk_SCT_push(fixture.sct_list, sct);
fixture.sct_dir = ct_dir;
fixture.sct_text_file = "tls1.sct";
EXECUTE_CT_TEST();
}
-int main(int argc, char *argv[])
+/*
+ * Tests that the CT_POLICY_EVAL_CTX default time is approximately now.
+ * Allow +-10 minutes, as it may compensate for clock skew.
+ */
+static int test_default_ct_policy_eval_ctx_time_is_now()
{
- int result = 0;
- char *tmp_env = NULL;
+ int success = 0;
+ CT_POLICY_EVAL_CTX *ct_policy_ctx = CT_POLICY_EVAL_CTX_new();
+ const time_t default_time = CT_POLICY_EVAL_CTX_get_time(ct_policy_ctx) /
+ 1000;
+ const time_t time_tolerance = 600; /* 10 minutes */
- tmp_env = getenv("OPENSSL_DEBUG_MEMORY");
- if (tmp_env != NULL && strcmp(tmp_env, "on") == 0)
- CRYPTO_set_mem_debug(1);
- CRYPTO_mem_ctrl(CRYPTO_MEM_CHECK_ON);
+ if (!TEST_uint_le(fabs(difftime(time(NULL), default_time)), time_tolerance))
+ goto end;
+
+ success = 1;
+end:
+ CT_POLICY_EVAL_CTX_free(ct_policy_ctx);
+ return success;
+}
- tmp_env = getenv("CT_DIR");
- ct_dir = OPENSSL_strdup(tmp_env != NULL ? tmp_env : "ct");
- tmp_env = getenv("CERTS_DIR");
- certs_dir = OPENSSL_strdup(tmp_env != NULL ? tmp_env : "certs");
+int test_main(int argc, char *argv[])
+{
+ if ((ct_dir = getenv("CT_DIR")) == NULL)
+ ct_dir = "ct";
+ if ((certs_dir = getenv("CERTS_DIR")) == NULL)
+ certs_dir = "certs";
ADD_TEST(test_no_scts_in_certificate);
ADD_TEST(test_one_sct_in_certificate);
ADD_TEST(test_multiple_scts_in_certificate);
ADD_TEST(test_verify_one_sct);
ADD_TEST(test_verify_multiple_scts);
+ ADD_TEST(test_verify_fails_for_future_sct);
ADD_TEST(test_decode_tls_sct);
ADD_TEST(test_encode_tls_sct);
+ ADD_TEST(test_default_ct_policy_eval_ctx_time_is_now);
- result = run_tests(argv[0]);
- ERR_print_errors_fp(stderr);
-
- OPENSSL_free(ct_dir);
- OPENSSL_free(certs_dir);
-
-#ifndef OPENSSL_NO_CRYPTO_MDEBUG
- if (CRYPTO_mem_leaks_fp(stderr) <= 0)
- result = 1;
-#endif
-
- return result;
+ return run_tests(argv[0]);
}
-
-#else /* OPENSSL_NO_CT */
-
-int main(int argc, char* argv[])
+#else
+int test_main(int argc, char *argv[])
{
- return EXIT_SUCCESS;
+ printf("No CT support\n");
+ return 0;
}
-
-#endif /* OPENSSL_NO_CT */
+#endif
projects / openssl.git / blobdiff