process_pci_value: free (*policy)->data before setting to NULL after failed realloc
[openssl.git] / crypto / x509v3 / v3_lib.c
index 1ed79e48e2e6fb1c1e0133e3adc059c6be3d8a22..0f1e1d4422b1d9c5cd561bc3ab25009de3530534 100644 (file)
@@ -1,5 +1,5 @@
 /* v3_lib.c */
-/* Written by Dr Stephen N Henson (shenson@bigfoot.com) for the OpenSSL
+/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
  * project 1999.
  */
 /* ====================================================================
 
 #include "ext_dat.h"
 
-static STACK *ext_list = NULL;
+static STACK_OF(X509V3_EXT_METHOD) *ext_list = NULL;
 
-static int ext_cmp(X509V3_EXT_METHOD **a, X509V3_EXT_METHOD **b);
+static int ext_cmp(const X509V3_EXT_METHOD * const *a,
+               const X509V3_EXT_METHOD * const *b);
 static void ext_list_free(X509V3_EXT_METHOD *ext);
 
 int X509V3_EXT_add(X509V3_EXT_METHOD *ext)
 {
-       if(!ext_list && !(ext_list = sk_new(ext_cmp))) {
+       if(!ext_list && !(ext_list = sk_X509V3_EXT_METHOD_new(ext_cmp))) {
                X509V3err(X509V3_F_X509V3_EXT_ADD,ERR_R_MALLOC_FAILURE);
                return 0;
        }
-       if(!sk_push(ext_list, (char *)ext)) {
+       if(!sk_X509V3_EXT_METHOD_push(ext_list, ext)) {
                X509V3err(X509V3_F_X509V3_EXT_ADD,ERR_R_MALLOC_FAILURE);
                return 0;
        }
        return 1;
 }
 
-static int ext_cmp(X509V3_EXT_METHOD **a, X509V3_EXT_METHOD **b)
+static int ext_cmp(const X509V3_EXT_METHOD * const *a,
+                  const X509V3_EXT_METHOD * const *b)
 {
        return ((*a)->ext_nid - (*b)->ext_nid);
 }
 
-X509V3_EXT_METHOD *X509V3_EXT_get_nid(int nid)
+DECLARE_OBJ_BSEARCH_CMP_FN(const X509V3_EXT_METHOD *, const X509V3_EXT_METHOD *,
+                          ext);
+IMPLEMENT_OBJ_BSEARCH_CMP_FN(const X509V3_EXT_METHOD *,
+                            const X509V3_EXT_METHOD *, ext);
+
+const X509V3_EXT_METHOD *X509V3_EXT_get_nid(int nid)
 {
-       X509V3_EXT_METHOD tmp, *t = &tmp, **ret;
+       X509V3_EXT_METHOD tmp;
+       const X509V3_EXT_METHOD *t = &tmp, * const *ret;
        int idx;
        if(nid < 0) return NULL;
        tmp.ext_nid = nid;
-       ret = (X509V3_EXT_METHOD **) OBJ_bsearch((char *)&t,
-                       (char *)standard_exts, STANDARD_EXTENSION_COUNT,
-                       sizeof(X509V3_EXT_METHOD *), (int (*)())ext_cmp);
+       ret = OBJ_bsearch_ext(&t, standard_exts, STANDARD_EXTENSION_COUNT);
        if(ret) return *ret;
        if(!ext_list) return NULL;
-       idx = sk_find(ext_list, (char *)&tmp);
+       idx = sk_X509V3_EXT_METHOD_find(ext_list, &tmp);
        if(idx == -1) return NULL;
-       return (X509V3_EXT_METHOD *)sk_value(ext_list, idx);
+       return sk_X509V3_EXT_METHOD_value(ext_list, idx);
 }
 
-X509V3_EXT_METHOD *X509V3_EXT_get(X509_EXTENSION *ext)
+const X509V3_EXT_METHOD *X509V3_EXT_get(X509_EXTENSION *ext)
 {
        int nid;
        if((nid = OBJ_obj2nid(ext->object)) == NID_undef) return NULL;
@@ -120,30 +126,32 @@ int X509V3_EXT_add_list(X509V3_EXT_METHOD *extlist)
 
 int X509V3_EXT_add_alias(int nid_to, int nid_from)
 {
-       X509V3_EXT_METHOD *ext, *tmpext;
+       const X509V3_EXT_METHOD *ext;
+       X509V3_EXT_METHOD *tmpext;
+
        if(!(ext = X509V3_EXT_get_nid(nid_from))) {
                X509V3err(X509V3_F_X509V3_EXT_ADD_ALIAS,X509V3_R_EXTENSION_NOT_FOUND);
                return 0;
        }
-       if(!(tmpext = (X509V3_EXT_METHOD *)Malloc(sizeof(X509V3_EXT_METHOD)))) {
+       if(!(tmpext = (X509V3_EXT_METHOD *)OPENSSL_malloc(sizeof(X509V3_EXT_METHOD)))) {
                X509V3err(X509V3_F_X509V3_EXT_ADD_ALIAS,ERR_R_MALLOC_FAILURE);
                return 0;
        }
        *tmpext = *ext;
        tmpext->ext_nid = nid_to;
        tmpext->ext_flags |= X509V3_EXT_DYNAMIC;
-       return 1;
+       return X509V3_EXT_add(tmpext);
 }
 
 void X509V3_EXT_cleanup(void)
 {
-       sk_pop_free(ext_list, ext_list_free);
+       sk_X509V3_EXT_METHOD_pop_free(ext_list, ext_list_free);
        ext_list = NULL;
 }
 
 static void ext_list_free(X509V3_EXT_METHOD *ext)
 {
-       if(ext->ext_flags & X509V3_EXT_DYNAMIC) Free(ext);
+       if(ext->ext_flags & X509V3_EXT_DYNAMIC) OPENSSL_free(ext);
 }
 
 /* Legacy function: we don't need to add standard extensions
@@ -159,10 +167,12 @@ int X509V3_add_standard_extensions(void)
 
 void *X509V3_EXT_d2i(X509_EXTENSION *ext)
 {
-       X509V3_EXT_METHOD *method;
-       unsigned char *p;
-       if(!(method = X509V3_EXT_get(ext)) || !method->d2i) return NULL;
+       const X509V3_EXT_METHOD *method;
+       const unsigned char *p;
+
+       if(!(method = X509V3_EXT_get(ext))) return NULL;
        p = ext->value->data;
+       if(method->it) return ASN1_item_d2i(NULL, &p, ext->value->length, ASN1_ITEM_ptr(method->it));
        return method->d2i(NULL, &p, ext->value->length);
 }
 
@@ -199,6 +209,7 @@ void *X509V3_get_d2i(STACK_OF(X509_EXTENSION) *x, int nid, int *crit, int *idx)
                if(OBJ_obj2nid(ex->object) == nid) {
                        if(idx) {
                                *idx = i;
+                               found_ex = ex;
                                break;
                        } else if(found_ex) {
                                /* Found more than one */
@@ -210,29 +221,89 @@ void *X509V3_get_d2i(STACK_OF(X509_EXTENSION) *x, int nid, int *crit, int *idx)
        }
        if(found_ex) {
                /* Found it */
-               if(crit) *crit = found_ex->critical;
+               if(crit) *crit = X509_EXTENSION_get_critical(found_ex);
                return X509V3_EXT_d2i(found_ex);
        }
-       
+
        /* Extension not found */
        if(idx) *idx = -1;
        if(crit) *crit = -1;
        return NULL;
 }
 
-/* As above but for a passed certificate */
+/* This function is a general extension append, replace and delete utility.
+ * The precise operation is governed by the 'flags' value. The 'crit' and
+ * 'value' arguments (if relevant) are the extensions internal structure.
+ */
 
-void *X509V3_X509_get_d2i(X509 *x, int nid, int *crit, int *idx)
+int X509V3_add1_i2d(STACK_OF(X509_EXTENSION) **x, int nid, void *value,
+                                       int crit, unsigned long flags)
 {
-       return X509V3_get_d2i(x->cert_info->extensions, nid, crit, idx);
-}
+       int extidx = -1;
+       int errcode;
+       X509_EXTENSION *ext, *extmp;
+       unsigned long ext_op = flags & X509V3_ADD_OP_MASK;
 
-void *X509V3_CRL_get_d2i(X509_CRL *x, int nid, int *crit, int *idx)
-{
-       return X509V3_get_d2i(x->crl->extensions, nid, crit, idx);
-}
+       /* If appending we don't care if it exists, otherwise
+        * look for existing extension.
+        */
+       if(ext_op != X509V3_ADD_APPEND)
+               extidx = X509v3_get_ext_by_NID(*x, nid, -1);
 
-void *X509V3_REVOKED_get_d2i(X509_REVOKED *x, int nid, int *crit, int *idx)
-{
-       return X509V3_get_d2i(x->extensions, nid, crit, idx);
+       /* See if extension exists */
+       if(extidx >= 0) {
+               /* If keep existing, nothing to do */
+               if(ext_op == X509V3_ADD_KEEP_EXISTING)
+                       return 1;
+               /* If default then its an error */
+               if(ext_op == X509V3_ADD_DEFAULT) {
+                       errcode = X509V3_R_EXTENSION_EXISTS;
+                       goto err;
+               }
+               /* If delete, just delete it */
+               if(ext_op == X509V3_ADD_DELETE) {
+                       if(!sk_X509_EXTENSION_delete(*x, extidx)) return -1;
+                       return 1;
+               }
+       } else {
+               /* If replace existing or delete, error since 
+                * extension must exist
+                */
+               if((ext_op == X509V3_ADD_REPLACE_EXISTING) ||
+                  (ext_op == X509V3_ADD_DELETE)) {
+                       errcode = X509V3_R_EXTENSION_NOT_FOUND;
+                       goto err;
+               }
+       }
+
+       /* If we get this far then we have to create an extension:
+        * could have some flags for alternative encoding schemes...
+        */
+
+       ext = X509V3_EXT_i2d(nid, crit, value);
+
+       if(!ext) {
+               X509V3err(X509V3_F_X509V3_ADD1_I2D, X509V3_R_ERROR_CREATING_EXTENSION);
+               return 0;
+       }
+
+       /* If extension exists replace it.. */
+       if(extidx >= 0) {
+               extmp = sk_X509_EXTENSION_value(*x, extidx);
+               X509_EXTENSION_free(extmp);
+               if(!sk_X509_EXTENSION_set(*x, extidx, ext)) return -1;
+               return 1;
+       }
+
+       if(!*x && !(*x = sk_X509_EXTENSION_new_null())) return -1;
+       if(!sk_X509_EXTENSION_push(*x, ext)) return -1;
+
+       return 1;
+
+       err:
+       if(!(flags & X509V3_ADD_SILENT))
+               X509V3err(X509V3_F_X509V3_ADD1_I2D, errcode);
+       return 0;
 }
+
+IMPLEMENT_STACK_OF(X509V3_EXT_METHOD)