Fix OID handling:
[openssl.git] / crypto / objects / obj_dat.c
index 34866ebbd28b095af2961c8b9c546c4761f1431d..bf89bc7b161f5e4cef69fcb6d131d7460042e113 100644 (file)
 
 #include <stdio.h>
 #include <ctype.h>
+#include <limits.h>
 #include "cryptlib.h"
-#include "lhash.h"
-#include "asn1.h"
-#include "objects.h"
+#include <openssl/lhash.h>
+#include <openssl/asn1.h>
+#include <openssl/objects.h>
+#include <openssl/bn.h>
 
 /* obj_dat.h is generated from objects.h by obj_dat.pl */
+#ifndef OPENSSL_NO_OBJECT
 #include "obj_dat.h"
-
-#ifndef NOPROTO
-static int sn_cmp(ASN1_OBJECT **a, ASN1_OBJECT **b);
-static int ln_cmp(ASN1_OBJECT **a, ASN1_OBJECT **b);
-static int obj_cmp(ASN1_OBJECT **a, ASN1_OBJECT **b);
 #else
-static int sn_cmp();
-static int ln_cmp();
-static int obj_cmp();
+/* You will have to load all the objects needed manually in the application */
+#define NUM_NID 0
+#define NUM_SN 0
+#define NUM_LN 0
+#define NUM_OBJ 0
+static const unsigned char lvalues[1];
+static const ASN1_OBJECT nid_objs[1];
+static const unsigned int sn_objs[1];
+static const unsigned int ln_objs[1];
+static const unsigned int obj_objs[1];
 #endif
 
+DECLARE_OBJ_BSEARCH_CMP_FN(const ASN1_OBJECT *, unsigned int, sn);
+DECLARE_OBJ_BSEARCH_CMP_FN(const ASN1_OBJECT *, unsigned int, ln);
+DECLARE_OBJ_BSEARCH_CMP_FN(const ASN1_OBJECT *, unsigned int, obj);
+
 #define ADDED_DATA     0
 #define ADDED_SNAME    1
 #define ADDED_LNAME    2
@@ -86,24 +95,24 @@ typedef struct added_obj_st
        int type;
        ASN1_OBJECT *obj;
        } ADDED_OBJ;
+DECLARE_LHASH_OF(ADDED_OBJ);
 
 static int new_nid=NUM_NID;
-static LHASH *added=NULL;
+static LHASH_OF(ADDED_OBJ) *added=NULL;
+
+static int sn_cmp(const ASN1_OBJECT * const *a, const unsigned int *b)
+       { return(strcmp((*a)->sn,nid_objs[*b].sn)); }
+
+IMPLEMENT_OBJ_BSEARCH_CMP_FN(const ASN1_OBJECT *, unsigned int, sn);
 
-static int sn_cmp(ap,bp)
-ASN1_OBJECT **ap;
-ASN1_OBJECT **bp;
-       { return(strcmp((*ap)->sn,(*bp)->sn)); }
+static int ln_cmp(const ASN1_OBJECT * const *a, const unsigned int *b)
+       { return(strcmp((*a)->ln,nid_objs[*b].ln)); }
 
-static int ln_cmp(ap,bp)
-ASN1_OBJECT **ap;
-ASN1_OBJECT **bp;
-       { return(strcmp((*ap)->ln,(*bp)->ln)); }
+IMPLEMENT_OBJ_BSEARCH_CMP_FN(const ASN1_OBJECT *, unsigned int, ln);
 
-static unsigned long add_hash(ca)
-ADDED_OBJ *ca;
+static unsigned long added_obj_hash(const ADDED_OBJ *ca)
        {
-       ASN1_OBJECT *a;
+       const ASN1_OBJECT *a;
        int i;
        unsigned long ret=0;
        unsigned char *p;
@@ -127,15 +136,16 @@ ADDED_OBJ *ca;
                ret=a->nid;
                break;
        default:
-               abort();
+               /* abort(); */
+               return 0;
                }
        ret&=0x3fffffffL;
-       ret|=ca->type<<30L;
+       ret|=((unsigned long)ca->type)<<30L;
        return(ret);
        }
+static IMPLEMENT_LHASH_HASH_FN(added_obj, ADDED_OBJ)
 
-static int add_cmp(ca,cb)
-ADDED_OBJ *ca,*cb;
+static int added_obj_cmp(const ADDED_OBJ *ca, const ADDED_OBJ *cb)
        {
        ASN1_OBJECT *a,*b;
        int i;
@@ -149,7 +159,7 @@ ADDED_OBJ *ca,*cb;
        case ADDED_DATA:
                i=(a->length - b->length);
                if (i) return(i);
-               return(memcmp(a->data,b->data,a->length));
+               return(memcmp(a->data,b->data,(size_t)a->length));
        case ADDED_SNAME:
                if (a->sn == NULL) return(-1);
                else if (b->sn == NULL) return(1);
@@ -161,50 +171,71 @@ ADDED_OBJ *ca,*cb;
        case ADDED_NID:
                return(a->nid-b->nid);
        default:
-               abort();
+               /* abort(); */
+               return 0;
                }
        }
+static IMPLEMENT_LHASH_COMP_FN(added_obj, ADDED_OBJ)
 
-static int init_added()
+static int init_added(void)
        {
        if (added != NULL) return(1);
-       added=lh_new(add_hash,add_cmp);
+       added=lh_ADDED_OBJ_new();
        return(added != NULL);
        }
 
-static void cleanup1(a)
-ADDED_OBJ *a;
+static void cleanup1_doall(ADDED_OBJ *a)
        {
        a->obj->nid=0;
        a->obj->flags|=ASN1_OBJECT_FLAG_DYNAMIC|
-                       ASN1_OBJECT_FLAG_DYNAMIC_STRINGS;
+                       ASN1_OBJECT_FLAG_DYNAMIC_STRINGS|
+                       ASN1_OBJECT_FLAG_DYNAMIC_DATA;
        }
 
-static void cleanup2(a)
-ADDED_OBJ *a;
+static void cleanup2_doall(ADDED_OBJ *a)
        { a->obj->nid++; }
 
-static void cleanup3(a)
-ADDED_OBJ *a;
+static void cleanup3_doall(ADDED_OBJ *a)
        {
        if (--a->obj->nid == 0)
                ASN1_OBJECT_free(a->obj);
-       Free(a);
+       OPENSSL_free(a);
+       }
+
+static IMPLEMENT_LHASH_DOALL_FN(cleanup1, ADDED_OBJ)
+static IMPLEMENT_LHASH_DOALL_FN(cleanup2, ADDED_OBJ)
+static IMPLEMENT_LHASH_DOALL_FN(cleanup3, ADDED_OBJ)
+
+/* The purpose of obj_cleanup_defer is to avoid EVP_cleanup() attempting
+ * to use freed up OIDs. If necessary the actual freeing up of OIDs is
+ * delayed.
+ */
+
+int obj_cleanup_defer = 0;
+
+void check_defer(int nid)
+       {
+       if (!obj_cleanup_defer && nid >= NUM_NID)
+                       obj_cleanup_defer = 1;
        }
 
-void OBJ_cleanup()
+void OBJ_cleanup(void)
        {
+       if (obj_cleanup_defer)
+               {
+               obj_cleanup_defer = 2;
+               return ;
+               }
        if (added == NULL) return;
-       added->down_load=0;
-       lh_doall(added,cleanup1); /* zero counters */
-       lh_doall(added,cleanup2); /* set counters */
-       lh_doall(added,cleanup3); /* free objects */
-       lh_free(added);
+       lh_ADDED_OBJ_down_load(added) = 0;
+       lh_ADDED_OBJ_doall(added,LHASH_DOALL_FN(cleanup1)); /* zero counters */
+       lh_ADDED_OBJ_doall(added,LHASH_DOALL_FN(cleanup2)); /* set counters */
+       lh_ADDED_OBJ_doall(added,LHASH_DOALL_FN(cleanup3)); /* free objects */
+       lh_ADDED_OBJ_free(added);
        added=NULL;
        }
 
-int OBJ_new_nid(num)
-int num;
+int OBJ_new_nid(int num)
        {
        int i;
 
@@ -213,27 +244,22 @@ int num;
        return(i);
        }
 
-int OBJ_add_object(obj)
-ASN1_OBJECT *obj;
+int OBJ_add_object(const ASN1_OBJECT *obj)
        {
        ASN1_OBJECT *o;
-       ADDED_OBJ *ao[4],*aop;
+       ADDED_OBJ *ao[4]={NULL,NULL,NULL,NULL},*aop;
        int i;
 
        if (added == NULL)
                if (!init_added()) return(0);
        if ((o=OBJ_dup(obj)) == NULL) goto err;
-       ao[ADDED_DATA]=NULL;
-       ao[ADDED_SNAME]=NULL;
-       ao[ADDED_LNAME]=NULL;
-       ao[ADDED_NID]=NULL;
-       ao[ADDED_NID]=(ADDED_OBJ *)Malloc(sizeof(ADDED_OBJ));
+       if (!(ao[ADDED_NID]=(ADDED_OBJ *)OPENSSL_malloc(sizeof(ADDED_OBJ)))) goto err2;
        if ((o->length != 0) && (obj->data != NULL))
-               ao[ADDED_DATA]=(ADDED_OBJ *)Malloc(sizeof(ADDED_OBJ));
+               if (!(ao[ADDED_DATA]=(ADDED_OBJ *)OPENSSL_malloc(sizeof(ADDED_OBJ)))) goto err2;
        if (o->sn != NULL)
-               ao[ADDED_SNAME]=(ADDED_OBJ *)Malloc(sizeof(ADDED_OBJ));
+               if (!(ao[ADDED_SNAME]=(ADDED_OBJ *)OPENSSL_malloc(sizeof(ADDED_OBJ)))) goto err2;
        if (o->ln != NULL)
-               ao[ADDED_LNAME]=(ADDED_OBJ *)Malloc(sizeof(ADDED_OBJ));
+               if (!(ao[ADDED_LNAME]=(ADDED_OBJ *)OPENSSL_malloc(sizeof(ADDED_OBJ)))) goto err2;
 
        for (i=ADDED_DATA; i<=ADDED_NID; i++)
                {
@@ -241,23 +267,26 @@ ASN1_OBJECT *obj;
                        {
                        ao[i]->type=i;
                        ao[i]->obj=o;
-                       aop=(ADDED_OBJ *)lh_insert(added,(char *)ao[i]);
+                       aop=lh_ADDED_OBJ_insert(added,ao[i]);
                        /* memory leak, buit should not normally matter */
                        if (aop != NULL)
-                               Free(aop);
+                               OPENSSL_free(aop);
                        }
                }
-       o->flags&= ~(ASN1_OBJECT_FLAG_DYNAMIC|ASN1_OBJECT_FLAG_DYNAMIC_STRINGS);
+       o->flags&= ~(ASN1_OBJECT_FLAG_DYNAMIC|ASN1_OBJECT_FLAG_DYNAMIC_STRINGS|
+                       ASN1_OBJECT_FLAG_DYNAMIC_DATA);
+
        return(o->nid);
+err2:
+       OBJerr(OBJ_F_OBJ_ADD_OBJECT,ERR_R_MALLOC_FAILURE);
 err:
        for (i=ADDED_DATA; i<=ADDED_NID; i++)
-               if (ao[i] != NULL) Free(ao[i]);
-       if (o != NULL) Free(o);
+               if (ao[i] != NULL) OPENSSL_free(ao[i]);
+       if (o != NULL) OPENSSL_free(o);
        return(NID_undef);
        }
 
-ASN1_OBJECT *OBJ_nid2obj(n)
-int n;
+ASN1_OBJECT *OBJ_nid2obj(int n)
        {
        ADDED_OBJ ad,*adp;
        ASN1_OBJECT ob;
@@ -278,7 +307,7 @@ int n;
                ad.type=ADDED_NID;
                ad.obj= &ob;
                ob.nid=n;
-               adp=(ADDED_OBJ *)lh_retrieve(added,(char *)&ad);
+               adp=lh_ADDED_OBJ_retrieve(added,&ad);
                if (adp != NULL)
                        return(adp->obj);
                else
@@ -289,8 +318,7 @@ int n;
                }
        }
 
-char *OBJ_nid2sn(n)
-int n;
+const char *OBJ_nid2sn(int n)
        {
        ADDED_OBJ ad,*adp;
        ASN1_OBJECT ob;
@@ -311,7 +339,7 @@ int n;
                ad.type=ADDED_NID;
                ad.obj= &ob;
                ob.nid=n;
-               adp=(ADDED_OBJ *)lh_retrieve(added,(char *)&ad);
+               adp=lh_ADDED_OBJ_retrieve(added,&ad);
                if (adp != NULL)
                        return(adp->obj->sn);
                else
@@ -322,8 +350,7 @@ int n;
                }
        }
 
-char *OBJ_nid2ln(n)
-int n;
+const char *OBJ_nid2ln(int n)
        {
        ADDED_OBJ ad,*adp;
        ASN1_OBJECT ob;
@@ -344,7 +371,7 @@ int n;
                ad.type=ADDED_NID;
                ad.obj= &ob;
                ob.nid=n;
-               adp=(ADDED_OBJ *)lh_retrieve(added,(char *)&ad);
+               adp=lh_ADDED_OBJ_retrieve(added,&ad);
                if (adp != NULL)
                        return(adp->obj->ln);
                else
@@ -355,10 +382,22 @@ int n;
                }
        }
 
-int OBJ_obj2nid(a)
-ASN1_OBJECT *a;
+static int obj_cmp(const ASN1_OBJECT * const *ap, const unsigned int *bp)
        {
-       ASN1_OBJECT **op;
+       int j;
+       const ASN1_OBJECT *a= *ap;
+       const ASN1_OBJECT *b= &nid_objs[*bp];
+
+       j=(a->length - b->length);
+        if (j) return(j);
+       return(memcmp(a->data,b->data,a->length));
+       }
+
+IMPLEMENT_OBJ_BSEARCH_CMP_FN(const ASN1_OBJECT *, unsigned int, obj);
+
+int OBJ_obj2nid(const ASN1_OBJECT *a)
+       {
+       const unsigned int *op;
        ADDED_OBJ ad,*adp;
 
        if (a == NULL)
@@ -369,116 +408,290 @@ ASN1_OBJECT *a;
        if (added != NULL)
                {
                ad.type=ADDED_DATA;
-               ad.obj=a;
-               adp=(ADDED_OBJ *)lh_retrieve(added,(char *)&ad);
+               ad.obj=(ASN1_OBJECT *)a; /* XXX: ugly but harmless */
+               adp=lh_ADDED_OBJ_retrieve(added,&ad);
                if (adp != NULL) return (adp->obj->nid);
                }
-       op=(ASN1_OBJECT **)OBJ_bsearch((char *)&a,(char *)obj_objs,NUM_OBJ,
-               sizeof(ASN1_OBJECT *),(int (*)())obj_cmp);
+       op=OBJ_bsearch_obj(&a, obj_objs, NUM_OBJ);
        if (op == NULL)
                return(NID_undef);
-       return((*op)->nid);
+       return(nid_objs[*op].nid);
        }
 
-int OBJ_txt2nid(s)
-char *s;
+/* Convert an object name into an ASN1_OBJECT
+ * if "noname" is not set then search for short and long names first.
+ * This will convert the "dotted" form into an object: unlike OBJ_txt2nid
+ * it can be used with any objects, not just registered ones.
+ */
+
+ASN1_OBJECT *OBJ_txt2obj(const char *s, int no_name)
        {
-       int ret;
+       int nid = NID_undef;
+       ASN1_OBJECT *op=NULL;
+       unsigned char *buf;
+       unsigned char *p;
+       const unsigned char *cp;
+       int i, j;
+
+       if(!no_name) {
+               if( ((nid = OBJ_sn2nid(s)) != NID_undef) ||
+                       ((nid = OBJ_ln2nid(s)) != NID_undef) ) 
+                                       return OBJ_nid2obj(nid);
+       }
+
+       /* Work out size of content octets */
+       i=a2d_ASN1_OBJECT(NULL,0,s,-1);
+       if (i <= 0) {
+               /* Don't clear the error */
+               /*ERR_clear_error();*/
+               return NULL;
+       }
+       /* Work out total size */
+       j = ASN1_object_size(0,i,V_ASN1_OBJECT);
+
+       if((buf=(unsigned char *)OPENSSL_malloc(j)) == NULL) return NULL;
+
+       p = buf;
+       /* Write out tag+length */
+       ASN1_put_object(&p,0,i,V_ASN1_OBJECT,V_ASN1_UNIVERSAL);
+       /* Write out contents */
+       a2d_ASN1_OBJECT(p,i,s,-1);
 
-       ret=OBJ_sn2nid(s);
-       if (ret == NID_undef)
+       cp=buf;
+       op=d2i_ASN1_OBJECT(NULL,&cp,j);
+       OPENSSL_free(buf);
+       return op;
+       }
+
+int OBJ_obj2txt(char *buf, int buf_len, const ASN1_OBJECT *a, int no_name)
+{
+       int i,n=0,len,nid, first, use_bn;
+       BIGNUM *bl;
+       unsigned long l;
+       const unsigned char *p;
+       char tbuf[DECIMAL_SIZE(i)+DECIMAL_SIZE(l)+2];
+
+       /* Ensure that, at every state, |buf| is NUL-terminated. */
+       if (buf && buf_len > 0)
+               buf[0] = '\0';
+
+       if ((a == NULL) || (a->data == NULL))
+               return(0);
+
+       if (!no_name && (nid=OBJ_obj2nid(a)) != NID_undef)
                {
-               ret=OBJ_ln2nid(s);
-               if (ret == NID_undef)
+               const char *s;
+               s=OBJ_nid2ln(nid);
+               if (s == NULL)
+                       s=OBJ_nid2sn(nid);
+               if (s)
                        {
-                       ASN1_OBJECT *op=NULL;
-                       unsigned char *buf,*p;
-                       int i;
+                       if (buf)
+                               BUF_strlcpy(buf,s,buf_len);
+                       n=strlen(s);
+                       return n;
+                       }
+               }
+
+
+       len=a->length;
+       p=a->data;
+
+       first = 1;
+       bl = NULL;
 
-                       i=a2d_ASN1_OBJECT(NULL,0,s,-1);
-                       if (i <= 0)
+       while (len > 0)
+               {
+               l=0;
+               use_bn = 0;
+               for (;;)
+                       {
+                       unsigned char c = *p++;
+                       len--;
+                       if ((len == 0) && (c & 0x80))
+                               goto err;
+                       if (use_bn)
                                {
-                               /* clear the error */
-                               ERR_get_error();
-                               return(0);
+                               if (!BN_add_word(bl, c & 0x7f))
+                                       goto err;
                                }
+                       else
+                               l |= c  & 0x7f;
+                       if (!(c & 0x80))
+                               break;
+                       if (!use_bn && (l > (ULONG_MAX >> 7L)))
+                               {
+                               if (!bl && !(bl = BN_new()))
+                                       goto err;
+                               if (!BN_set_word(bl, l))
+                                       goto err;
+                               use_bn = 1;
+                               }
+                       if (use_bn)
+                               {
+                               if (!BN_lshift(bl, bl, 7))
+                                       goto err;
+                               }
+                       else
+                               l<<=7L;
+                       }
 
-                       if ((buf=(unsigned char *)Malloc(i)) == NULL)
-                               return(NID_undef);
-                       a2d_ASN1_OBJECT(buf,i,s,-1);
-                       p=buf;
-                       op=d2i_ASN1_OBJECT(NULL,&p,i);
-                       if (op == NULL) return(NID_undef);
-                       ret=OBJ_obj2nid(op);
-                       ASN1_OBJECT_free(op);
-                       Free(buf);
+               if (first)
+                       {
+                       first = 0;
+                       if (l >= 80)
+                               {
+                               i = 2;
+                               if (use_bn)
+                                       {
+                                       if (!BN_sub_word(bl, 80))
+                                               goto err;
+                                       }
+                               else
+                                       l -= 80;
+                               }
+                       else
+                               {
+                               i=(int)(l/40);
+                               l-=(long)(i*40);
+                               }
+                       if (buf && (buf_len > 1))
+                               {
+                               *buf++ = i + '0';
+                               *buf = '\0';
+                               buf_len--;
+                               }
+                       n++;
+                       }
+
+               if (use_bn)
+                       {
+                       char *bndec;
+                       bndec = BN_bn2dec(bl);
+                       if (!bndec)
+                               goto err;
+                       i = strlen(bndec);
+                       if (buf)
+                               {
+                               if (buf_len > 1)
+                                       {
+                                       *buf++ = '.';
+                                       *buf = '\0';
+                                       buf_len--;
+                                       }
+                               BUF_strlcpy(buf,bndec,buf_len);
+                               if (i > buf_len)
+                                       {
+                                       buf += buf_len;
+                                       buf_len = 0;
+                                       }
+                               else
+                                       {
+                                       buf+=i;
+                                       buf_len-=i;
+                                       }
+                               }
+                       n++;
+                       n += i;
+                       OPENSSL_free(bndec);
+                       }
+               else
+                       {
+                       BIO_snprintf(tbuf,sizeof tbuf,".%lu",l);
+                       i=strlen(tbuf);
+                       if (buf && (buf_len > 0))
+                               {
+                               BUF_strlcpy(buf,tbuf,buf_len);
+                               if (i > buf_len)
+                                       {
+                                       buf += buf_len;
+                                       buf_len = 0;
+                                       }
+                               else
+                                       {
+                                       buf+=i;
+                                       buf_len-=i;
+                                       }
+                               }
+                       n+=i;
+                       l=0;
                        }
                }
-       return(ret);
-       }
 
-int OBJ_ln2nid(s)
-char *s;
+       if (bl)
+               BN_free(bl);
+       return n;
+
+       err:
+       if (bl)
+               BN_free(bl);
+       return -1;
+}
+
+int OBJ_txt2nid(const char *s)
+{
+       ASN1_OBJECT *obj;
+       int nid;
+       obj = OBJ_txt2obj(s, 0);
+       nid = OBJ_obj2nid(obj);
+       ASN1_OBJECT_free(obj);
+       return nid;
+}
+
+int OBJ_ln2nid(const char *s)
        {
-       ASN1_OBJECT o,*oo= &o,**op;
+       ASN1_OBJECT o;
+       const ASN1_OBJECT *oo= &o;
        ADDED_OBJ ad,*adp;
+       const unsigned int *op;
 
        o.ln=s;
        if (added != NULL)
                {
                ad.type=ADDED_LNAME;
                ad.obj= &o;
-               adp=(ADDED_OBJ *)lh_retrieve(added,(char *)&ad);
+               adp=lh_ADDED_OBJ_retrieve(added,&ad);
                if (adp != NULL) return (adp->obj->nid);
                }
-       op=(ASN1_OBJECT **)OBJ_bsearch((char *)&oo,(char *)ln_objs,NUM_LN,
-               sizeof(ASN1_OBJECT *),(int (*)())ln_cmp);
+       op=OBJ_bsearch_ln(&oo, ln_objs, NUM_LN);
        if (op == NULL) return(NID_undef);
-       return((*op)->nid);
+       return(nid_objs[*op].nid);
        }
 
-int OBJ_sn2nid(s)
-char *s;
+int OBJ_sn2nid(const char *s)
        {
-       ASN1_OBJECT o,*oo= &o,**op;
+       ASN1_OBJECT o;
+       const ASN1_OBJECT *oo= &o;
        ADDED_OBJ ad,*adp;
+       const unsigned int *op;
 
        o.sn=s;
        if (added != NULL)
                {
                ad.type=ADDED_SNAME;
                ad.obj= &o;
-               adp=(ADDED_OBJ *)lh_retrieve(added,(char *)&ad);
+               adp=lh_ADDED_OBJ_retrieve(added,&ad);
                if (adp != NULL) return (adp->obj->nid);
                }
-       op=(ASN1_OBJECT **)OBJ_bsearch((char *)&oo,(char *)sn_objs,NUM_SN,
-               sizeof(ASN1_OBJECT *),(int (*)())sn_cmp);
+       op=OBJ_bsearch_sn(&oo, sn_objs, NUM_SN);
        if (op == NULL) return(NID_undef);
-       return((*op)->nid);
+       return(nid_objs[*op].nid);
        }
 
-static int obj_cmp(ap, bp)
-ASN1_OBJECT **ap;
-ASN1_OBJECT **bp;
+const void *OBJ_bsearch_(const void *key, const void *base, int num, int size,
+                        int (*cmp)(const void *, const void *))
        {
-       int j;
-       ASN1_OBJECT *a= *ap;
-       ASN1_OBJECT *b= *bp;
+       return OBJ_bsearch_ex_(key, base, num, size, cmp, 0);
+       }
 
-       j=(a->length - b->length);
-        if (j) return(j);
-       return(memcmp(a->data,b->data,a->length));
-        }
-
-char *OBJ_bsearch(key,base,num,size,cmp)
-char *key;
-char *base;
-int num;
-int size;
-int (*cmp)();
+const void *OBJ_bsearch_ex_(const void *key, const void *base_, int num,
+                           int size,
+                           int (*cmp)(const void *, const void *),
+                           int flags)
        {
-       int l,h,i,c;
-       char *p;
+       const char *base=base_;
+       int l,h,i=0,c=0;
+       const char *p = NULL;
 
        if (num == 0) return(NULL);
        l=0;
@@ -493,16 +706,39 @@ int (*cmp)();
                else if (c > 0)
                        l=i+1;
                else
-                       return(p);
+                       break;
                }
-       return(NULL);
+#ifdef CHARSET_EBCDIC
+/* THIS IS A KLUDGE - Because the *_obj is sorted in ASCII order, and
+ * I don't have perl (yet), we revert to a *LINEAR* search
+ * when the object wasn't found in the binary search.
+ */
+       if (c != 0)
+               {
+               for (i=0; i<num; ++i)
+                       {
+                       p= &(base[i*size]);
+                       c = (*cmp)(key,p);
+                       if (c == 0 || (c < 0 && (flags & OBJ_BSEARCH_VALUE_ON_NOMATCH)))
+                               return p;
+                       }
+               }
+#endif
+       if (c != 0 && !(flags & OBJ_BSEARCH_VALUE_ON_NOMATCH))
+               p = NULL;
+       else if (c == 0 && (flags & OBJ_BSEARCH_FIRST_VALUE_ON_MATCH))
+               {
+               while(i > 0 && (*cmp)(key,&(base[(i-1)*size])) == 0)
+                       i--;
+               p = &(base[i*size]);
+               }
+       return(p);
        }
 
-int OBJ_create_objects(in)
-BIO *in;
+int OBJ_create_objects(BIO *in)
        {
        MS_STATIC char buf[512];
-       int i,num= -1;
+       int i,num=0;
        char *o,*s,*l=NULL;
 
        for (;;)
@@ -511,26 +747,26 @@ BIO *in;
                i=BIO_gets(in,buf,512);
                if (i <= 0) return(num);
                buf[i-1]='\0';
-               if (!isalnum(buf[0])) return(num);
+               if (!isalnum((unsigned char)buf[0])) return(num);
                o=s=buf;
-               while (isdigit(*s) || (*s == '.'))
+               while (isdigit((unsigned char)*s) || (*s == '.'))
                        s++;
                if (*s != '\0')
                        {
                        *(s++)='\0';
-                       while (isspace(*s))
+                       while (isspace((unsigned char)*s))
                                s++;
                        if (*s == '\0')
                                s=NULL;
                        else
                                {
                                l=s;
-                               while ((*l != '\0') && !isspace(*l))
+                               while ((*l != '\0') && !isspace((unsigned char)*l))
                                        l++;
                                if (*l != '\0')
                                        {
                                        *(l++)='\0';
-                                       while (isspace(*l))
+                                       while (isspace((unsigned char)*l))
                                                l++;
                                        if (*l == '\0') l=NULL;
                                        }
@@ -544,13 +780,10 @@ BIO *in;
                if (!OBJ_create(o,s,l)) return(num);
                num++;
                }
-       return(num);
+       /* return(num); */
        }
 
-int OBJ_create(oid,sn,ln)
-char *oid;
-char *sn;
-char *ln;
+int OBJ_create(const char *oid, const char *sn, const char *ln)
        {
        int ok=0;
        ASN1_OBJECT *op=NULL;
@@ -560,19 +793,20 @@ char *ln;
        i=a2d_ASN1_OBJECT(NULL,0,oid,-1);
        if (i <= 0) return(0);
 
-       if ((buf=(unsigned char *)Malloc(i)) == NULL)
+       if ((buf=(unsigned char *)OPENSSL_malloc(i)) == NULL)
                {
-               OBJerr(OBJ_F_OBJ_CREATE,OBJ_R_MALLOC_FAILURE);
+               OBJerr(OBJ_F_OBJ_CREATE,ERR_R_MALLOC_FAILURE);
                return(0);
                }
        i=a2d_ASN1_OBJECT(buf,i,oid,-1);
+       if (i == 0)
+               goto err;
        op=(ASN1_OBJECT *)ASN1_OBJECT_create(OBJ_new_nid(1),buf,i,sn,ln);
        if (op == NULL) 
                goto err;
        ok=OBJ_add_object(op);
 err:
        ASN1_OBJECT_free(op);
-       Free((char *)buf);
+       OPENSSL_free(buf);
        return(ok);
        }
-