From e3587da72ead14568de95a8fb1cf8198f71e4200 Mon Sep 17 00:00:00 2001 From: "Dr. Matthias St. Pierre" Date: Thu, 3 Oct 2019 23:34:14 +0200 Subject: [PATCH] cherry-checker: fix: don't choke on semicolons in the commit message title The semicolon is used as separator for the git output, so make sure to stop the line.split() after the third separator, otherwise the subject line might get split further. (see openssl/openssl@bd01733fdd Fix comment; unchecked->checked) Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/43) --- review-tools/cherry-checker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/review-tools/cherry-checker b/review-tools/cherry-checker index dbdbd06..318eee6 100755 --- a/review-tools/cherry-checker +++ b/review-tools/cherry-checker @@ -88,7 +88,7 @@ def pick_cherries(left, right, all = False): for line in subprocess.check_output(git_command).decode().splitlines(): - timestamp, branch, commit, subject = line.split(";") + timestamp, branch, commit, subject = line.split(";", maxsplit=3) if branch == '=' and not all: continue -- 2.34.1