From: Allan <allanchang96@gmail.com>
Date: Thu, 7 Jul 2022 23:04:09 +0000 (-0700)
Subject: Fix memory leak in X509V3_add1_i2d when flag is X509V3_ADD_DELETE
X-Git-Tag: openssl-3.2.0-alpha1~2411
X-Git-Url: https://git.openssl.org/?a=commitdiff_plain;h=4798e0680b112993815098ca21d7d68ff31ebc6e;p=openssl.git

Fix memory leak in X509V3_add1_i2d when flag is X509V3_ADD_DELETE

Fixes #18677

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18698)
---

diff --git a/crypto/x509/v3_lib.c b/crypto/x509/v3_lib.c
index 42b6ff1527..5c05b56d9c 100644
--- a/crypto/x509/v3_lib.c
+++ b/crypto/x509/v3_lib.c
@@ -242,8 +242,10 @@ int X509V3_add1_i2d(STACK_OF(X509_EXTENSION) **x, int nid, void *value,
         }
         /* If delete, just delete it */
         if (ext_op == X509V3_ADD_DELETE) {
-            if (!sk_X509_EXTENSION_delete(*x, extidx))
+            extmp = sk_X509_EXTENSION_delete(*x, extidx);
+            if (extmp == NULL)
                 return -1;
+            X509_EXTENSION_free(extmp);
             return 1;
         }
     } else {