test: coverity 1469426 - dereference after null check
authorPauli <ppzgs1@gmail.com>
Wed, 17 Mar 2021 03:09:06 +0000 (13:09 +1000)
committerPauli <ppzgs1@gmail.com>
Sat, 20 Mar 2021 00:18:32 +0000 (10:18 +1000)
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14589)

test/sslapitest.c

index b469d80a176bafb7d04d26da8d50ea9c0a3bc452..d46e73b3127831935dc63ebd4accbfd408a2dc10 100644 (file)
@@ -8297,7 +8297,7 @@ static EVP_PKEY *get_tmp_dh_params(void)
         OSSL_PARAM_BLD_free_params(params);
     }
 
-    if (!EVP_PKEY_up_ref(tmp_dh_params))
+    if (tmp_dh_params != NULL && !EVP_PKEY_up_ref(tmp_dh_params))
         return NULL;
 
     return tmp_dh_params;