Fix an incorrect error flow in add_provider_groups
authorMatt Caswell <matt@openssl.org>
Fri, 26 Jun 2020 19:44:27 +0000 (20:44 +0100)
committerMatt Caswell <matt@openssl.org>
Wed, 8 Jul 2020 07:55:56 +0000 (08:55 +0100)
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/12292)

ssl/t1_lib.c

index c9097fcc44876cad11f8e63685944c7aff53a4e7..41228d58e9d0039d98a152e26fe6f9bcaa63e56c 100644 (file)
@@ -334,7 +334,7 @@ static int add_provider_groups(const OSSL_PARAM params[], void *data)
     p = OSSL_PARAM_locate_const(params, OSSL_CAPABILITY_TLS_GROUP_MAX_TLS);
     if (p == NULL || !OSSL_PARAM_get_int(p, &ginf->maxtls)) {
         SSLerr(0, ERR_R_PASSED_INVALID_ARGUMENT);
-        return 0;
+        goto err;
     }
 
     p = OSSL_PARAM_locate_const(params, OSSL_CAPABILITY_TLS_GROUP_MIN_DTLS);