Remove TODO comment from sskdf.c
authorShane Lontis <shane.lontis@oracle.com>
Sat, 26 Sep 2020 02:41:41 +0000 (12:41 +1000)
committerShane Lontis <shane.lontis@oracle.com>
Sun, 27 Sep 2020 22:59:35 +0000 (08:59 +1000)
Fixes #12993

The implementation follows the standards/recommendations specified by https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-56Cr2.pdf.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/12999)

providers/implementations/kdfs/sskdf.c

index 22c65d26ba736dd0cf14b99b46f7b815efde32f1..04c1fb6f5415d309a5ebd69fa38e7ca14dfa1bbc 100644 (file)
@@ -371,11 +371,6 @@ static int sskdf_derive(void *vctx, unsigned char *key, size_t keylen)
         int default_salt_len;
         EVP_MAC *mac = EVP_MAC_CTX_mac(ctx->macctx);
 
-        /*
-         * TODO(3.0) investigate the necessity to have all these controls.
-         * Why does KMAC require a salt length that's shorter than the MD
-         * block size?
-         */
         if (EVP_MAC_is_a(mac, OSSL_MAC_NAME_HMAC)) {
             /* H(x) = HMAC(x, salt, hash) */
             if (md == NULL) {