Fix comment in do_dtls1_write()
authorBenjamin Kaduk <bkaduk@akamai.com>
Sun, 29 Nov 2020 01:11:46 +0000 (17:11 -0800)
committerBenjamin Kaduk <kaduk@mit.edu>
Wed, 2 Dec 2020 21:43:06 +0000 (13:43 -0800)
This code started off as a copy of ssl3_write_bytes(), and the comment
was not updated with the implementation.

Reported by yangyangtiantianlonglong in #13518

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/13566)

ssl/record/rec_layer_d1.c

index 53ac5eebbc8010c627b929d92b683e14ce189278..cc412bae3751a3c73de654837c51b1e37096555b 100644 (file)
@@ -800,8 +800,8 @@ int do_dtls1_write(SSL *s, int type, const unsigned char *buf,
     wb = &s->rlayer.wbuf[0];
 
     /*
-     * first check if there is a SSL3_BUFFER still being written out.  This
-     * will happen with non blocking IO
+     * DTLS writes whole datagrams, so there can't be anything left in
+     * the buffer.
      */
     if (!ossl_assert(SSL3_BUFFER_get_left(wb) == 0)) {
         SSLfatal(s, SSL_AD_INTERNAL_ERROR, ERR_R_INTERNAL_ERROR);