Adjust error reason for ssl_get_min_max_version() failure
authorBenjamin Kaduk <bkaduk@akamai.com>
Mon, 26 Oct 2020 19:35:55 +0000 (12:35 -0700)
committerBenjamin Kaduk <bkaduk@akamai.com>
Mon, 2 Nov 2020 19:28:24 +0000 (11:28 -0800)
Use SSL_R_NO_PROTOCOLS_AVAILABLE instead of ERR_R_INTERNAL_ERROR,
to match what the BoringSSL tests expect for this case.

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/13251)

ssl/statem/statem_lib.c

index ef4067a749539567b6dd8242896f54968fc50423..422c631838c977037517a4161d46445bf639b121 100644 (file)
@@ -101,8 +101,8 @@ int tls_setup_handshake(SSL *s)
     memset(s->ext.extflags, 0, sizeof(s->ext.extflags));
 
     if (ssl_get_min_max_version(s, &ver_min, &ver_max, NULL) != 0) {
-        SSLfatal(s, SSL_AD_INTERNAL_ERROR, SSL_F_TLS_SETUP_HANDSHAKE,
-                    ERR_R_INTERNAL_ERROR);
+        SSLfatal(s, SSL_AD_PROTOCOL_VERSION, SSL_F_TLS_SETUP_HANDSHAKE,
+                    SSL_R_NO_PROTOCOLS_AVAILABLE);
         return 0;
     }