test: fix coverity 1454040: resource leak
authorPauli <ppzgs1@gmail.com>
Thu, 18 Mar 2021 00:31:33 +0000 (10:31 +1000)
committerPauli <ppzgs1@gmail.com>
Sat, 20 Mar 2021 00:07:59 +0000 (10:07 +1000)
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14596)

test/cmp_asn_test.c

index 33cc03cb4c1571d6fbd9d59c5d7b9af7d1007685..c021ed03a691f775b2be7020b08da259700e1b40 100644 (file)
@@ -42,12 +42,15 @@ static void tear_down(CMP_ASN_TEST_FIXTURE *fixture)
 
 static int execute_cmp_asn1_get_int_test(CMP_ASN_TEST_FIXTURE *fixture)
 {
+    int res;
     ASN1_INTEGER *asn1integer = ASN1_INTEGER_new();
-    ASN1_INTEGER_set(asn1integer, 77);
-    if (!TEST_int_eq(77, ossl_cmp_asn1_get_int(asn1integer)))
+
+    if (!TEST_ptr(asn1integer))
         return 0;
+    ASN1_INTEGER_set(asn1integer, 77);
+    res = TEST_int_eq(77, ossl_cmp_asn1_get_int(asn1integer));
     ASN1_INTEGER_free(asn1integer);
-    return 1;
+    return res;
 }
 
 static int test_cmp_asn1_get_int(void)