Fix C code generate by 'openssl dsaparam -C'.

openssl · Jan 10, 2001 · c06648f · c06648f
1 parent cd56182
commit c06648f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGES b/CHANGES
@@ -3,6 +3,10 @@
 
  Changes between 0.9.6 and 0.9.7  [xx XXX 2000]
 
+  *) Fix C code generated by 'openssl dsaparam -C': If a BN_bin2bn
+     call failed, free the DSA structure.
+     [Bodo Moeller]
+
   *) Add another call level for memory allocation routines, thereby
      allowing memory allocation callbacks that can be given file
      name and line number information.  The basic functionality

diff --git a/apps/dsaparam.c b/apps/dsaparam.c
@@ -338,7 +338,7 @@ int MAIN(int argc, char **argv)
 		printf("\tdsa->g=BN_bin2bn(dsa%d_g,sizeof(dsa%d_g),NULL);\n",
 			bits_p,bits_p);
 		printf("\tif ((dsa->p == NULL) || (dsa->q == NULL) || (dsa->g == NULL))\n");
-		printf("\t\treturn(NULL);\n");
+		printf("\t\t{ DSA_free(dsa); return(NULL); }\n");
 		printf("\treturn(dsa);\n\t}\n");
 		}