Skip to content

Commit

Permalink
Check DTLS_BAD_VER for version number.
Browse files Browse the repository at this point in the history
The version check for DTLS1_VERSION was redundant as
DTLS1_VERSION > TLS1_1_VERSION, however we do need to
check for DTLS1_BAD_VER for compatibility.

PR:2984
  • Loading branch information
dwmw2 authored and snhenson committed Feb 12, 2013
1 parent b7c37f2 commit d980abb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ssl/s3_cbc.c
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ int tls1_cbc_remove_padding(const SSL* s,
unsigned padding_length, good, to_check, i;
const unsigned overhead = 1 /* padding length byte */ + mac_size;
/* Check if version requires explicit IV */
if (s->version >= TLS1_1_VERSION || s->version == DTLS1_VERSION)
if (s->version >= TLS1_1_VERSION || s->version == DTLS1_BAD_VER)
{
/* These lengths are all public so we can test them in
* non-constant time.
Expand Down

0 comments on commit d980abb

Please sign in to comment.