Fix ssl_get_prev_session overrun
authorMatt Caswell <matt@openssl.org>
Fri, 10 Apr 2015 15:49:33 +0000 (16:49 +0100)
committerMatt Caswell <matt@openssl.org>
Tue, 14 Apr 2015 13:59:40 +0000 (14:59 +0100)
commit5101c35c9173e40051acb23e45aae128fb84806e
tree68087fa1cc7b4450db3021f54e7f60153645bce4
parent35bac9167644d167aee57c26df206ed5f2b2a877
Fix ssl_get_prev_session overrun

If OpenSSL is configured with no-tlsext then ssl_get_prev_session can read
past the end of the ClientHello message if the session_id length in the
ClientHello is invalid. This should not cause any security issues since the
underlying buffer is 16k in size. It should never be possible to overrun by
that many bytes.

This is probably made redundant by the previous commit - but you can never be
too careful.

With thanks to Qinghao Tang for reporting this issue.

Reviewed-by: Rich Salz <rsalz@openssl.org>
(cherry picked from commit 5e0a80c1c9b2b06c2d203ad89778ce1b98e0b5ad)
ssl/ssl_sess.c