From: Matt Caswell <matt@openssl.org>
Date: Mon, 10 Sep 2018 15:23:14 +0000 (+0100)
Subject: Check the return value from ASN1_INTEGER_set
X-Git-Tag: OpenSSL_1_0_2q~26
X-Git-Url: https://git.openssl.org/gitweb/?a=commitdiff_plain;h=4a98bb0068cae9fbe5c6a6e513093d41969dad58;p=openssl.git

Check the return value from ASN1_INTEGER_set

Found by Coverity

Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/7169)

(cherry picked from commit 512d811719fc955f574090af4c3586a9aba46fa7)
---

diff --git a/crypto/pkcs12/p12_init.c b/crypto/pkcs12/p12_init.c
index 0322df944a..8275a23fb5 100644
--- a/crypto/pkcs12/p12_init.c
+++ b/crypto/pkcs12/p12_init.c
@@ -70,7 +70,8 @@ PKCS12 *PKCS12_init(int mode)
         PKCS12err(PKCS12_F_PKCS12_INIT, ERR_R_MALLOC_FAILURE);
         return NULL;
     }
-    ASN1_INTEGER_set(pkcs12->version, 3);
+    if (!ASN1_INTEGER_set(pkcs12->version, 3))
+        goto err;
     pkcs12->authsafes->type = OBJ_nid2obj(mode);
     switch (mode) {
     case NID_pkcs7_data: