Constify ASN1_TYPE_cmp add X509_ALGOR_cmp.
authorDr. Stephen Henson <steve@openssl.org>
Sun, 14 Dec 2014 23:14:15 +0000 (23:14 +0000)
committerDr. Stephen Henson <steve@openssl.org>
Mon, 5 Jan 2015 14:57:39 +0000 (14:57 +0000)
Reviewed-by: Emilia Käsper <emilia@openssl.org>
(cherry picked from commit 4c52816d35681c0533c25fdd3abb4b7c6962302d)

Conflicts:
crypto/asn1/x_algor.c
crypto/x509/x509.h

crypto/asn1/a_type.c
crypto/asn1/asn1.h
crypto/asn1/x_algor.c
crypto/x509/x509.h

index a45d2f9d12ddbc52088b2c3fa2ab260695417965..5e1bc762d08bf67eb19ad9409e9cb4e114e15a45 100644 (file)
@@ -113,7 +113,7 @@ IMPLEMENT_STACK_OF(ASN1_TYPE)
 IMPLEMENT_ASN1_SET_OF(ASN1_TYPE)
 
 /* Returns 0 if they are equal, != 0 otherwise. */
-int ASN1_TYPE_cmp(ASN1_TYPE *a, ASN1_TYPE *b)
+int ASN1_TYPE_cmp(const ASN1_TYPE *a, const ASN1_TYPE *b)
        {
        int result = -1;
 
index 9197ea4b4c4a5fb3229d55e387fce9bcb90118bf..689ef8a3ab8b99fbad76e8c0f892398b4ebf4a4f 100644 (file)
@@ -777,7 +777,7 @@ DECLARE_ASN1_FUNCTIONS_fname(ASN1_TYPE, ASN1_ANY, ASN1_TYPE)
 int ASN1_TYPE_get(ASN1_TYPE *a);
 void ASN1_TYPE_set(ASN1_TYPE *a, int type, void *value);
 int ASN1_TYPE_set1(ASN1_TYPE *a, int type, const void *value);
-int            ASN1_TYPE_cmp(ASN1_TYPE *a, ASN1_TYPE *b);
+int            ASN1_TYPE_cmp(const ASN1_TYPE *a, const ASN1_TYPE *b);
 
 ASN1_OBJECT *  ASN1_OBJECT_new(void );
 void           ASN1_OBJECT_free(ASN1_OBJECT *a);
index 99e53429b797960f635363ded6ce1d24e7189204..acc41bacca6e991864bf43eb36e206428f87a061 100644 (file)
@@ -128,3 +128,13 @@ void X509_ALGOR_get0(ASN1_OBJECT **paobj, int *pptype, void **ppval,
                }
        }
 
+int X509_ALGOR_cmp(const X509_ALGOR *a, const X509_ALGOR *b)
+       {
+       int rv;
+       rv = OBJ_cmp(a->algorithm, b->algorithm);
+       if (rv)
+               return rv;
+       if (!a->parameter && !b->parameter)
+               return 0;
+       return ASN1_TYPE_cmp(a->parameter, b->parameter);
+       }
index e6f8a40395b08c6f8cbfec733243a552031c816d..2900777e00b7d45fb1c85251a7b8bde4b6552bab 100644 (file)
@@ -763,6 +763,7 @@ X509_ALGOR *X509_ALGOR_dup(X509_ALGOR *xn);
 int X509_ALGOR_set0(X509_ALGOR *alg, ASN1_OBJECT *aobj, int ptype, void *pval);
 void X509_ALGOR_get0(ASN1_OBJECT **paobj, int *pptype, void **ppval,
                                                X509_ALGOR *algor);
+int X509_ALGOR_cmp(const X509_ALGOR *a, const X509_ALGOR *b);
 
 X509_NAME *X509_NAME_dup(X509_NAME *xn);
 X509_NAME_ENTRY *X509_NAME_ENTRY_dup(X509_NAME_ENTRY *ne);