Reject excessively large primes in DH key generation.
authorGuido Vranken <guidovranken@gmail.com>
Mon, 11 Jun 2018 17:38:54 +0000 (19:38 +0200)
committerMatt Caswell <matt@openssl.org>
Tue, 12 Jun 2018 09:30:14 +0000 (10:30 +0100)
CVE-2018-0732

Signed-off-by: Guido Vranken <guidovranken@gmail.com>
(cherry picked from commit 91f7361f47b082ae61ffe1a7b17bb2adf213c7fe)

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/6457)

crypto/dh/dh_key.c

index 387558f1467c813e0e2a2e6c52778593c6bed100..f235e0d682b130fb5bd7b2ebb9cb84b6c104de51 100644 (file)
@@ -130,10 +130,15 @@ static int generate_key(DH *dh)
     int ok = 0;
     int generate_new_key = 0;
     unsigned l;
-    BN_CTX *ctx;
+    BN_CTX *ctx = NULL;
     BN_MONT_CTX *mont = NULL;
     BIGNUM *pub_key = NULL, *priv_key = NULL;
 
+    if (BN_num_bits(dh->p) > OPENSSL_DH_MAX_MODULUS_BITS) {
+        DHerr(DH_F_GENERATE_KEY, DH_R_MODULUS_TOO_LARGE);
+        return 0;
+    }
+
     ctx = BN_CTX_new();
     if (ctx == NULL)
         goto err;