Reject elliptic curve lists of odd lengths.
authorEmilia Kasper <emilia@openssl.org>
Mon, 1 Dec 2014 14:04:02 +0000 (15:04 +0100)
committerEmilia Kasper <emilia@openssl.org>
Fri, 5 Dec 2014 15:44:12 +0000 (16:44 +0100)
commitf6e725e86816fa9301d87c25e3dff9de2ebb7176
tree9c766796a08ff926647a3c47d6eca523aff734f9
parent7005eda3b6e4858233ec3d2a95ff3f5f28f8a484
Reject elliptic curve lists of odd lengths.

The Supported Elliptic Curves extension contains a vector of NamedCurves
of 2 bytes each, so the total length must be even. Accepting odd-length
lists was observed to lead to a non-exploitable one-byte out-of-bounds
read in the latest development branches (1.0.2 and master). Released
versions of OpenSSL are not affected.

Thanks to Felix Groebert of the Google Security Team for reporting this issue.

Reviewed-by: Matt Caswell <matt@openssl.org>
(cherry picked from commit 33d5ba862939ff8db70a9e36fc9a326fab3e8d98)
ssl/t1_lib.c